From: David Miller <davem@davemloft.net>
To: socketcan@hartkopp.net
Cc: hawkes@google.com, urs.thuermann@volkswagen.de, netdev@vger.kernel.org
Subject: Re: [PATCH] can: add limit for nframes and clean up signed/unsigned variables
Date: Wed, 11 Aug 2010 16:12:48 -0700 (PDT) [thread overview]
Message-ID: <20100811.161248.104043270.davem@davemloft.net> (raw)
In-Reply-To: <4C627102.1080205@hartkopp.net>
From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: Wed, 11 Aug 2010 11:44:34 +0200
> This patch adds a limit for nframes as the number of frames in TX_SETUP and
> RX_SETUP are derived from a single byte multiplex value by default.
> Use-cases that would require to send/filter more than 256 CAN frames should
> be implemented in userspace for complexity reasons anyway.
>
> Additionally the assignments of unsigned values from userspace to signed
> values in kernelspace and vice versa are fixed by using unsigned values in
> kernelspace consistently.
>
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
> Reported-by: Ben Hawkes <hawkes@google.com>
> Acked-by: Urs Thuermann <urs.thuermann@volkswagen.de>
Applied and I'll queue this up for -stable, thanks.
prev parent reply other threads:[~2010-08-11 23:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 9:44 [PATCH] can: add limit for nframes and clean up signed/unsigned variables Oliver Hartkopp
2010-08-11 23:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100811.161248.104043270.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hawkes@google.com \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=urs.thuermann@volkswagen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).