Netdev List
 help / color / mirror / Atom feed
From: Roopa Prabhu <roprabhu@cisco.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: [net-next-2.6 PATCH 5/7] enic: Clean up: remove enic_dev_stats_clear
Date: Tue, 10 Aug 2010 21:55:15 -0700	[thread overview]
Message-ID: <20100811045515.3877.68840.stgit@savbu-pc100.cisco.com> (raw)
In-Reply-To: <20100811045436.3877.51650.stgit@savbu-pc100.cisco.com>

From: Roopa Prabhu <roprabhu@cisco.com>

Remove function enic_dev_stats_clear and its reference in enic device
init code. Firmware clears device stats on device open. So, no need for
the driver to do it again.

Signed-off-by: Scott Feldman <scofeldm@cisco.com>
Signed-off-by: Roopa Prabhu <roprabhu@cisco.com>
Signed-off-by: Vasanthy Kolluri <vkolluri@cisco.com>
---
 drivers/net/enic/enic_main.c |   15 ---------------
 1 files changed, 0 insertions(+), 15 deletions(-)


diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index 07aa033..d08f362 100644
--- a/drivers/net/enic/enic_main.c
+++ b/drivers/net/enic/enic_main.c
@@ -2167,17 +2167,6 @@ void enic_dev_deinit(struct enic *enic)
 	enic_clear_intr_mode(enic);
 }
 
-static int enic_dev_stats_clear(struct enic *enic)
-{
-	int err;
-
-	spin_lock(&enic->devcmd_lock);
-	err = vnic_dev_stats_clear(enic->vdev);
-	spin_unlock(&enic->devcmd_lock);
-
-	return err;
-}
-
 int enic_dev_init(struct enic *enic)
 {
 	struct device *dev = enic_get_dev(enic);
@@ -2220,10 +2209,6 @@ int enic_dev_init(struct enic *enic)
 
 	enic_init_vnic_resources(enic);
 
-	/* Clear LIF stats
-	 */
-	enic_dev_stats_clear(enic);
-
 	err = enic_set_rq_alloc_buf(enic);
 	if (err) {
 		dev_err(dev, "Failed to set RQ buffer allocator, aborting\n");


  parent reply	other threads:[~2010-08-11  4:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-11  4:54 [net-next-2.6 PATCH 0/7] enic: updates to version 1.4.1.2 Roopa Prabhu
2010-08-11  4:54 ` [net-next-2.6 PATCH 1/7] enic: Add set mac address Roopa Prabhu
2010-08-11  4:55 ` [net-next-2.6 PATCH 2/7] enic: Add support for firmware management device Roopa Prabhu
2010-08-11  4:55 ` [net-next-2.6 PATCH 3/7] enic: Add new firmware devcmds Roopa Prabhu
2010-08-11  4:55 ` [net-next-2.6 PATCH 4/7] enic: Use offsetof macro in vic tlv length calculation Roopa Prabhu
2010-08-11  4:55 ` Roopa Prabhu [this message]
2010-08-11  4:55 ` [net-next-2.6 PATCH 6/7] enic: Check if rq/wq buf not NULL before freeing them Roopa Prabhu
2010-08-11  4:55 ` [net-next-2.6 PATCH 7/7] enic: Mark intr_timer in vnic_enet_config as deprecated Roopa Prabhu
2010-08-17  9:35 ` [net-next-2.6 PATCH 0/7] enic: updates to version 1.4.1.2 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100811045515.3877.68840.stgit@savbu-pc100.cisco.com \
    --to=roprabhu@cisco.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox