From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_CAN driver to 2.6.35 Date: Wed, 11 Aug 2010 19:04:14 -0700 Message-ID: <20100812020414.GD14121@suse.de> References: <4C61EDE5.4030505@dsn.okisemi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Daniel Baluta , Masayuki Ohtak , "meego-dev@meego.com" , Wolfgang Grandegger , "socketcan-core@lists.berlios.de" , "netdev@vger.kernel.org" , "Khor, Andrew Chih Howe" , "arjan@linux.intel.com" , "Wang, Yong Y" To: "Wang, Qi" Return-path: Received: from cantor2.suse.de ([195.135.220.15]:58076 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933124Ab0HLCHY (ORCPT ); Wed, 11 Aug 2010 22:07:24 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Aug 12, 2010 at 09:42:27AM +0800, Wang, Qi wrote: > > -----Original Message----- > > From: Daniel Baluta [mailto:daniel.baluta@gmail.com] > > Sent: Wednesday, August 11, 2010 6:37 PM > > To: Masayuki Ohtak > > Cc: meego-dev@meego.com; Wolfgang Grandegger; > > socketcan-core@lists.berlios.de; netdev@vger.kernel.org; Khor, Andrew Chih > > Howe; gregkh@suse.de; arjan@linux.intel.com; Wang, Qi; Wang, Yong Y > > Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_CAN driver to 2.6.35 > > > > Hi, > > > > 2010/8/11 Masayuki Ohtak : > > > CAN driver of Topcliff PCH > > > > > > Topcliff PCH is the platform controller hub that is going to be used in > > > Intel's upcoming general embedded platform. All IO peripherals in > > > Topcliff PCH are actually devices sitting on AMBA bus. > > > Topcliff PCH has CAN I/F. This driver enables CAN function. > > > > > > Signed-off-by: Masayuki Ohtake > > > > I have a few questions: > > > > 1. Is your code based on Intel's CAN EP80579 ([1]) ? > No. > > 2. Why don't you use kernel existing kfifo infrastructure? ([2]). > Just take a look at kfifo.h. This structure has been changed. I > remembered there was a spin_lock from kfifo previously. Currently it's > been removed, good. > OKI-sans, would you please take a look at ./include/linux/kfifo.h, and try to use this structure and APIs? > > Daniel, > > We're anxious to integrate those codes now. Perhaps it'll take us > quite a long time to use kfifo. How about implementing it with the > next version? What do you mean by this? Code isn't merged into the tree unless it is correct. Please fix this now, it's not that big of a deal. > > 3. Can you provide a pointer to Topcliff PCH CAN I/F datasheet ? > Currently this datasheet isn't open. Even under NDA? The Linux foundation offers a service to allow developers access to data sheets so that they can do kernel development and code review. thanks, greg k-h