From: Stephen Hemminger <shemminger@vyatta.com>
To: Narendra K <Narendra_K@dell.com>
Cc: netdev@vger.kernel.org, matt_domsch@dell.com,
charles_rose@dell.com, jordan_hargrave@dell.com
Subject: Re: [PATCH] Add firmware label support to iproute2
Date: Thu, 12 Aug 2010 14:12:40 -0400 [thread overview]
Message-ID: <20100812141240.417949e2@s6510> (raw)
In-Reply-To: <20100812173537.GA29784@auslistsprd01.us.dell.com>
On Thu, 12 Aug 2010 12:35:37 -0500
Narendra K <Narendra_K@dell.com> wrote:
> +#ifndef LIBNETDEVNAME_PRESENT
> filter_dev = *argv;
> +#else
> + if (netdev_alias_to_kernelname(*argv, kernel_name) < 0)
> + show_firmware_alias_usage(*argv);
> + filter_dev = kernel_name;
> +#endif
> }
like the kernel, I don't like ifdef cases in main code.
You should put in stub inline that returns appropriate error.
What happens if alias matches existing interface name?
next prev parent reply other threads:[~2010-08-12 18:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 17:35 [PATCH] Add firmware label support to iproute2 Narendra K
2010-08-12 18:10 ` Stephen Hemminger
2010-08-12 18:12 ` Stephen Hemminger [this message]
2010-08-13 12:36 ` Narendra_K
2010-08-18 21:41 ` Stephen Hemminger
2010-08-19 21:33 ` Matt Domsch
2010-08-19 21:53 ` Stephen Hemminger
2010-08-19 22:18 ` Matt Domsch
2010-08-25 22:03 ` Matt Domsch
2010-08-25 22:16 ` Greg KH
2010-08-26 14:10 ` Matt Domsch
2010-08-26 0:16 ` Stephen Hemminger
2010-08-26 15:01 ` Matt Domsch
2010-08-26 15:17 ` Loke, Chetan
2010-08-26 15:21 ` Stephen Hemminger
2010-08-26 15:38 ` Loke, Chetan
2010-08-27 7:54 ` Kay Sievers
2010-08-26 16:38 ` Matt Domsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100812141240.417949e2@s6510 \
--to=shemminger@vyatta.com \
--cc=Narendra_K@dell.com \
--cc=charles_rose@dell.com \
--cc=jordan_hargrave@dell.com \
--cc=matt_domsch@dell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).