* [PATCH] ipv6: remove sysctl jiffies conversion on gc_elasticity and min_adv_ms
@ 2010-07-22 21:39 Min Zhang
2010-07-25 4:03 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Min Zhang @ 2010-07-22 21:39 UTC (permalink / raw)
To: netdev
sysctl output ipv6 gc_elasticity and min_adv_mss as values divided by
HZ. However, they are not in unit of jiffies, since ip6_rt_min_advmss
refers to packet size and ip6_rt_fc_elasticity is used as scaler as in
expire>>ip6_rt_gc_elasticity, so replace the jiffies conversion
handler will regular handler for them.
This has impact on scripts that are currently working assuming the
divide by HZ, will yield different results with this patch in place.
Signed-off-by: Min Zhang <mzhang@mvista.com>
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 252d761..3b3de49 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2583,7 +2583,7 @@ ctl_table ipv6_route_table_template[] = {
.data = &init_net.ipv6.sysctl.ip6_rt_gc_elasticity,
.maxlen = sizeof(int),
.mode = 0644,
- .proc_handler = proc_dointvec_jiffies,
+ .proc_handler = proc_dointvec,
},
{
.procname = "mtu_expires",
@@ -2597,7 +2597,7 @@ ctl_table ipv6_route_table_template[] = {
.data = &init_net.ipv6.sysctl.ip6_rt_min_advmss,
.maxlen = sizeof(int),
.mode = 0644,
- .proc_handler = proc_dointvec_jiffies,
+ .proc_handler = proc_dointvec,
},
{
.procname = "gc_min_interval_ms",
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ipv6: remove sysctl jiffies conversion on gc_elasticity and min_adv_ms
2010-07-22 21:39 Min Zhang
@ 2010-07-25 4:03 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2010-07-25 4:03 UTC (permalink / raw)
To: mzhang; +Cc: netdev
From: Min Zhang <mzhang@mvista.com>
Date: Thu, 22 Jul 2010 14:39:14 -0700
> sysctl output ipv6 gc_elasticity and min_adv_mss as values divided by
> HZ. However, they are not in unit of jiffies, since ip6_rt_min_advmss
> refers to packet size and ip6_rt_fc_elasticity is used as scaler as in
> expire>>ip6_rt_gc_elasticity, so replace the jiffies conversion
> handler will regular handler for them.
>
> This has impact on scripts that are currently working assuming the
> divide by HZ, will yield different results with this patch in place.
>
> Signed-off-by: Min Zhang <mzhang@mvista.com>
Your email client corrupted your patch, turning tab characters into
spaces. This makes your patch unusable.
Please resubmit this patch properly so that I can use it.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ipv6: remove sysctl jiffies conversion on gc_elasticity and min_adv_ms
@ 2010-08-13 19:50 Min Zhang
2010-08-15 5:43 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Min Zhang @ 2010-08-13 19:50 UTC (permalink / raw)
To: netdev
ipv6: remove sysctl jiffies conversion on gc_elasticity and min_adv_mss
sysctl output ipv6 gc_elasticity and min_adv_mss as values divided by
HZ. However, they are not in unit of jiffies, since ip6_rt_min_advmss
refers to packet size and ip6_rt_fc_elasticity is used as scaler as in
expire>>ip6_rt_gc_elasticity, so replace the jiffies conversion
handler will regular handler for them.
This has impact on scripts that are currently working assuming the
divide by HZ, will yield different results with this patch in place.
Signed-off-by: Min Zhang <mzhang@mvista.com>
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 252d761..3b3de49 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2583,7 +2583,7 @@ ctl_table ipv6_route_table_template[] = {
.data = &init_net.ipv6.sysctl.ip6_rt_gc_elasticity,
.maxlen = sizeof(int),
.mode = 0644,
- .proc_handler = proc_dointvec_jiffies,
+ .proc_handler = proc_dointvec,
},
{
.procname = "mtu_expires",
@@ -2597,7 +2597,7 @@ ctl_table ipv6_route_table_template[] = {
.data = &init_net.ipv6.sysctl.ip6_rt_min_advmss,
.maxlen = sizeof(int),
.mode = 0644,
- .proc_handler = proc_dointvec_jiffies,
+ .proc_handler = proc_dointvec,
},
{
.procname = "gc_min_interval_ms",
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ipv6: remove sysctl jiffies conversion on gc_elasticity and min_adv_ms
2010-08-13 19:50 [PATCH] ipv6: remove sysctl jiffies conversion on gc_elasticity and min_adv_ms Min Zhang
@ 2010-08-15 5:43 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2010-08-15 5:43 UTC (permalink / raw)
To: mzhang; +Cc: netdev
From: Min Zhang <mzhang@mvista.com>
Date: Fri, 13 Aug 2010 12:50:37 -0700 (PDT)
> ipv6: remove sysctl jiffies conversion on gc_elasticity and
> min_adv_mss
>
> sysctl output ipv6 gc_elasticity and min_adv_mss as values divided by
> HZ. However, they are not in unit of jiffies, since ip6_rt_min_advmss
> refers to packet size and ip6_rt_fc_elasticity is used as scaler as in
> expire>>ip6_rt_gc_elasticity, so replace the jiffies conversion
> handler will regular handler for them.
>
> This has impact on scripts that are currently working assuming the
> divide by HZ, will yield different results with this patch in place.
>
> Signed-off-by: Min Zhang <mzhang@mvista.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-08-15 5:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-13 19:50 [PATCH] ipv6: remove sysctl jiffies conversion on gc_elasticity and min_adv_ms Min Zhang
2010-08-15 5:43 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2010-07-22 21:39 Min Zhang
2010-07-25 4:03 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).