From: David Miller <davem@davemloft.net>
To: xeb@mail.ru
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 1/3] PPTP: PPP over IPv4 (Point-to-Point Tunneling Protocol)
Date: Mon, 16 Aug 2010 20:53:16 -0700 (PDT) [thread overview]
Message-ID: <20100816.205316.226783098.davem@davemloft.net> (raw)
In-Reply-To: <E1Ogws4-0000NO-00.xeb-mail-ru@f238.mail.ru>
Please make the following changes:
1) Remove all of the "DEBUG" stuff. First of all, you should never
TAB indent "#ifdef DEBUG" CPP checks like that, it's awfully
ugly and makes the code hard to read. Next you can use
pr_debug() or similar for things like this.
2) Combine all three patches into one single patch including everything.
There is no need to split things up like this.
Thank you.
next prev parent reply other threads:[~2010-08-17 3:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-05 9:36 [PATCH v2 1/3] PPTP: PPP over IPv4 (Point-to-Point Tunneling Protocol) Dmitry Kozlov
2010-08-17 3:53 ` David Miller [this message]
2010-08-18 5:56 ` Dmitry Kozlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100816.205316.226783098.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=xeb@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox