From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: rusty@rustcorp.com.au, netdev@vger.kernel.org, mst@redhat.com,
izumi.taku@jp.fujitsu.com
Subject: Re: [PATCH] ethtool: Provide a default implementation of ethtool_ops::get_drvinfo
Date: Tue, 17 Aug 2010 01:50:24 -0700 (PDT) [thread overview]
Message-ID: <20100817.015024.245415197.davem@davemloft.net> (raw)
In-Reply-To: <1281036008.2095.6.camel@achroite.uk.solarflarecom.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Thu, 05 Aug 2010 20:20:08 +0100
> The driver name and bus address for a net_device can normally be found
> through the driver model now. Instead of requiring drivers to provide
> this information redundantly through the ethtool_ops::get_drvinfo
> operation, use the driver model to do so if the driver does not define
> the operation. Since ETHTOOL_GDRVINFO no longer requires the driver
> to implement any operations, do not require net_device::ethtool_ops to
> be set either.
>
> Remove implementations of get_drvinfo and ethtool_ops that provide
> only this information.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Applied.
next prev parent reply other threads:[~2010-08-17 8:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-05 3:32 [PATCH] virtio_net: implements ethtool_ops.get_drvinfo Rusty Russell
2010-08-05 3:47 ` Ben Hutchings
2010-08-05 4:54 ` David Miller
2010-08-05 19:20 ` [PATCH] ethtool: Provide a default implementation of ethtool_ops::get_drvinfo Ben Hutchings
2010-08-17 8:50 ` David Miller [this message]
2010-08-06 15:59 ` [PATCH] virtio_net: implements ethtool_ops.get_drvinfo Loke, Chetan
2010-08-06 16:15 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100817.015024.245415197.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).