Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: amit.salecha@qlogic.com
Cc: netdev@vger.kernel.org, ameen.rahman@qlogic.com
Subject: Re: [PATCHv2 NEXT 0/7]qlcnic: enhancement and fixes
Date: Tue, 17 Aug 2010 02:43:14 -0700 (PDT)	[thread overview]
Message-ID: <20100817.024314.39173338.davem@davemloft.net> (raw)
In-Reply-To: <1281682646-15990-1-git-send-email-amit.salecha@qlogic.com>

From: Amit Kumar Salecha <amit.salecha@qlogic.com>
Date: Thu, 12 Aug 2010 23:57:19 -0700

> Hi
>    Sending v2 series of 7 patches. In previous set of patches author
>    email id was incorrect and a minor fix in lro/rxcsum patch.
>    Please ignore v1 patches.

Please respin this against net-next-2.6 and resubmit, as-is it doesn't
apply cleanly.

Also, patch #5 is not correct.  Use "netdev_info()" if you want the
netdev stuff printed properly in the link status message.  You're
undoing all of the work made such that all printk's in your driver are
consistent, by using the pr_fmt based interfaces (pr_*(), dev_*(),
netdev_*()).

      parent reply	other threads:[~2010-08-17  9:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-13  6:57 [PATCHv2 NEXT 0/7]qlcnic: enhancement and fixes Amit Kumar Salecha
2010-08-13  6:57 ` [PATCHv2 NEXT 1/7] qlcnic: fix aer for virtual func Amit Kumar Salecha
2010-08-13  6:57 ` [PATCHv2 NEXT 2/7] qlcnic: device state management fixes " Amit Kumar Salecha
2010-08-13  6:57 ` [PATCHv2 NEXT 3/7] qlcnic: fix for setting function modes Amit Kumar Salecha
2010-08-13  6:57 ` [PATCHv2 NEXT 4/7] qlcnic: add eswitch statistics support Amit Kumar Salecha
2010-08-13  6:57 ` [PATCHv2 NEXT 5/7] qlcnic: fix link status message Amit Kumar Salecha
2010-08-13  6:57 ` [PATCHv2 NEXT 6/7] qlcnic: fix link diag test Amit Kumar Salecha
2010-08-13  6:57 ` [PATCHv2 NEXT 7/7] qlcnic: turn off lro when rxcsum is disabled Amit Kumar Salecha
2010-08-17  9:43 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100817.024314.39173338.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ameen.rahman@qlogic.com \
    --cc=amit.salecha@qlogic.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox