From: David Miller <davem@davemloft.net>
To: jarkao2@gmail.com
Cc: xiaohui.xin@intel.com, netdev@vger.kernel.org,
herbert@gondor.apana.org.au
Subject: Re: [PATCH] net: Fix a memmove bug in dev_gro_receive()
Date: Tue, 17 Aug 2010 17:37:56 -0700 (PDT) [thread overview]
Message-ID: <20100817.173756.193693195.davem@davemloft.net> (raw)
In-Reply-To: <20100811120210.GA24019@ff.dom.local>
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Wed, 11 Aug 2010 12:02:10 +0000
>>Xin Xiaohui wrote:
>> I looked into the code dev_gro_receive(), found the code here:
>> if the frags[0] is pulled to 0, then the page will be released,
>> and memmove() frags left.
>> Is that right? I'm not sure if memmove do right or not, but
>> frags[0].size is never set after memove at least. what I think
>> a simple way is not to do anything if we found frags[0].size == 0.
>> The patch is as followed.
> ...
>
> This version of the patch fixes the bug directly in memmove.
>
> Reported-by: "Xin, Xiaohui" <xiaohui.xin@intel.com>
> Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Applied thanks a lot Jarek.
prev parent reply other threads:[~2010-08-18 0:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 1:54 Is it a possible bug in dev_gro_receive()? Xin Xiaohui
2010-08-02 10:29 ` Jarek Poplawski
2010-08-02 11:04 ` Herbert Xu
2010-08-03 2:33 ` Xin, Xiaohui
2010-08-03 6:45 ` Jarek Poplawski
2010-08-10 8:11 ` Xin, Xiaohui
2010-08-10 8:34 ` Jarek Poplawski
2010-08-11 12:02 ` [PATCH] net: Fix a memmove bug in dev_gro_receive() Jarek Poplawski
2010-08-18 0:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100817.173756.193693195.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiaohui.xin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).