From: David Miller <davem@davemloft.net>
To: rmody@brocade.com
Cc: netdev@vger.kernel.org, adapter_linux_open_src_team@brocade.com
Subject: Re: [PATCH 1/6] bna: Brocade 10Gb Ethernet device driver
Date: Tue, 17 Aug 2010 17:41:57 -0700 (PDT) [thread overview]
Message-ID: <20100817.174157.226783923.davem@davemloft.net> (raw)
In-Reply-To: <201008110424.o7B4OanK018594@blc-10-10.brocade.com>
From: Rasesh Mody <rmody@brocade.com>
Date: Tue, 10 Aug 2010 21:24:36 -0700
> +u32 bna_id;
This variable is never set by the driver.
It is always left at it's default value of zero and it is only
used to construct MBOX irq name strings and it is also assigned
to bnad->ident.id
I suspect it's completely useless, and if so please just delete
it.
next prev parent reply other threads:[~2010-08-18 0:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 4:24 [PATCH 1/6] bna: Brocade 10Gb Ethernet device driver Rasesh Mody
2010-08-18 0:41 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-08-23 21:24 Rasesh Mody
2010-08-07 3:23 Debashis Dutt
2010-08-09 15:15 ` Stephen Hemminger
2010-08-11 19:45 ` Debashis Dutt
2010-08-04 5:15 Rasesh Mody
2010-08-04 17:09 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100817.174157.226783923.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adapter_linux_open_src_team@brocade.com \
--cc=netdev@vger.kernel.org \
--cc=rmody@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).