From: David Miller <davem@davemloft.net>
To: xeb@mail.ru
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH v3] PPTP: PPP over IPv4 (Point-to-Point Tunneling Protocol)
Date: Wed, 18 Aug 2010 14:23:15 -0700 (PDT) [thread overview]
Message-ID: <20100818.142315.183039464.davem@davemloft.net> (raw)
In-Reply-To: <E1Olg2s-0007BB-00.xeb-mail-ru@f30.mail.ru>
From: Dmitry Kozlov <xeb@mail.ru>
Date: Wed, 18 Aug 2010 14:38:58 +0400
> Hi Eric!
> Thanks for comments. All your comments was accepted except:
>
>> > +static struct ppp_channel_ops pptp_chan_ops = {
>>
>> static const ?
>
> not, because po->chan.ops = &pptp_chan_ops which is not const
Yes it is:
davem@sunset:~/src/GIT/linux-2.6$ git grep ppp_channel_ops -- include/linux/
include/linux/ppp_channel.h:struct ppp_channel_ops {
include/linux/ppp_channel.h: const struct ppp_channel_ops *ops; /* operations for this channel */
davem@sunset:~/src/GIT/linux-2.6$
prev parent reply other threads:[~2010-08-18 21:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 5:55 [PATCH v3] PPTP: PPP over IPv4 (Point-to-Point Tunneling Protocol) Dmitry Kozlov
2010-08-18 8:25 ` Eric Dumazet
2010-08-18 10:38 ` Dmitry Kozlov
2010-08-18 21:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100818.142315.183039464.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xeb@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).