* Re: [PATCH 13/16] net/ax25: Use available error codes
[not found] <Pine.LNX.4.64.1008161828030.19313@ask.diku.dk>
@ 2010-08-16 19:31 ` Ralf Baechle
2010-08-18 21:28 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2010-08-16 19:31 UTC (permalink / raw)
To: Julia Lawall
Cc: Joerg Reuter, David S. Miller, linux-hams, linux-kernel, netdev,
kernel-janitors
On Mon, Aug 16, 2010 at 06:28:19PM +0200, Julia Lawall wrote:
> Error codes are stored in err, but the return value is always 0. Return
> err instead.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> local idexpression x;
> constant C;
> @@
>
> if (...) { ...
> x = -C
> ... when != x
> (
> return <+...x...+>;
> |
> return NULL;
> |
> return;
> |
> * return ...;
> )
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> This changes the semantics of the function and has not been tested.
It restores the semantics to what they should be and used to be. This
probably happened during the introduction of proper refcounting and
locking into the AX.25 stack. Looks fine to me.
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 13/16] net/ax25: Use available error codes
[not found] <Pine.LNX.4.64.1008161828030.19313@ask.diku.dk>
2010-08-16 19:31 ` [PATCH 13/16] net/ax25: Use available error codes Ralf Baechle
@ 2010-08-18 21:28 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2010-08-18 21:28 UTC (permalink / raw)
To: julia; +Cc: jreuter, ralf, linux-hams, linux-kernel, netdev, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Date: Mon, 16 Aug 2010 18:28:19 +0200 (CEST)
> From: Julia Lawall <julia@diku.dk>
>
> Error codes are stored in err, but the return value is always 0. Return
> err instead.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 13/16] net/ax25: Use available error codes
@ 2010-08-16 16:28 Julia Lawall
0 siblings, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2010-08-16 16:28 UTC (permalink / raw)
To: Joerg Reuter, Ralf Baechle, D, avid S. Miller, linux-hams,
linux-kernel, netdev
From: Julia Lawall <julia@diku.dk>
Error codes are stored in err, but the return value is always 0. Return
err instead.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
local idexpression x;
constant C;
@@
if (...) { ...
x = -C
... when != x
(
return <+...x...+>;
|
return NULL;
|
return;
|
* return ...;
)
}
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
This changes the semantics of the function and has not been tested.
net/ax25/af_ax25.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
index cfdfd7e..26eaebf 100644
--- a/net/ax25/af_ax25.c
+++ b/net/ax25/af_ax25.c
@@ -1103,7 +1103,7 @@ done:
out:
release_sock(sk);
- return 0;
+ return err;
}
/*
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-18 21:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <Pine.LNX.4.64.1008161828030.19313@ask.diku.dk>
2010-08-16 19:31 ` [PATCH 13/16] net/ax25: Use available error codes Ralf Baechle
2010-08-18 21:28 ` David Miller
2010-08-16 16:28 Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).