* [PATCH] greth: Use return value of register_netdev
@ 2010-08-17 16:11 Tobias Klauser
2010-08-19 7:05 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Tobias Klauser @ 2010-08-17 16:11 UTC (permalink / raw)
To: David S. Miller, Kristoffer Glembo, netdev; +Cc: kernel-janitors
Use the return value provided by register_netdev on error instead of
hard setting it to -ENOMEM.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
drivers/net/greth.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/greth.c b/drivers/net/greth.c
index f15c64f..fbeaf70 100644
--- a/drivers/net/greth.c
+++ b/drivers/net/greth.c
@@ -1547,10 +1547,10 @@ static int __devinit greth_of_probe(struct platform_device *ofdev, const struct
dev->netdev_ops = &greth_netdev_ops;
dev->ethtool_ops = &greth_ethtool_ops;
- if (register_netdev(dev)) {
+ err = register_netdev(dev);
+ if (err) {
if (netif_msg_probe(greth))
dev_err(greth->dev, "netdevice registration failed.\n");
- err = -ENOMEM;
goto error5;
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] greth: Use return value of register_netdev
@ 2010-08-17 16:12 Tobias Klauser
2010-08-17 16:14 ` Tobias Klauser
0 siblings, 1 reply; 4+ messages in thread
From: Tobias Klauser @ 2010-08-17 16:12 UTC (permalink / raw)
To: David S. Miller, netdev; +Cc: kernel-janitors
Use the return value provided by register_netdev on error instead of
hard setting it to -ENOMEM.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
drivers/net/greth.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/greth.c b/drivers/net/greth.c
index f15c64f..fbeaf70 100644
--- a/drivers/net/greth.c
+++ b/drivers/net/greth.c
@@ -1547,10 +1547,10 @@ static int __devinit greth_of_probe(struct platform_device *ofdev, const struct
dev->netdev_ops = &greth_netdev_ops;
dev->ethtool_ops = &greth_ethtool_ops;
- if (register_netdev(dev)) {
+ err = register_netdev(dev);
+ if (err) {
if (netif_msg_probe(greth))
dev_err(greth->dev, "netdevice registration failed.\n");
- err = -ENOMEM;
goto error5;
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] greth: Use return value of register_netdev
2010-08-17 16:12 Tobias Klauser
@ 2010-08-17 16:14 ` Tobias Klauser
0 siblings, 0 replies; 4+ messages in thread
From: Tobias Klauser @ 2010-08-17 16:14 UTC (permalink / raw)
To: David S. Miller, netdev; +Cc: kernel-janitors
On 2010-08-17 at 18:12:07 +0200, Tobias Klauser <tklauser@distanz.ch> wrote:
> Use the return value provided by register_netdev on error instead of
> hard setting it to -ENOMEM.
Sorry for the duplicate, please disregard this one.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] greth: Use return value of register_netdev
2010-08-17 16:11 [PATCH] greth: Use return value of register_netdev Tobias Klauser
@ 2010-08-19 7:05 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2010-08-19 7:05 UTC (permalink / raw)
To: tklauser; +Cc: kristoffer, netdev, kernel-janitors
From: Tobias Klauser <tklauser@distanz.ch>
Date: Tue, 17 Aug 2010 18:11:24 +0200
> Use the return value provided by register_netdev on error instead of
> hard setting it to -ENOMEM.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-08-19 7:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-17 16:11 [PATCH] greth: Use return value of register_netdev Tobias Klauser
2010-08-19 7:05 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2010-08-17 16:12 Tobias Klauser
2010-08-17 16:14 ` Tobias Klauser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).