* [PATCH] sunhme: Use return value of register_netdev
@ 2010-08-17 16:13 Tobias Klauser
2010-08-19 7:06 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Klauser @ 2010-08-17 16:13 UTC (permalink / raw)
To: David S. Miller, netdev; +Cc: kernel-janitors
Use the return value provided by register_netdev on error instead of
using a previously set value.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
drivers/net/sunhme.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/sunhme.c b/drivers/net/sunhme.c
index bd0df1c..d96431e 100644
--- a/drivers/net/sunhme.c
+++ b/drivers/net/sunhme.c
@@ -2808,7 +2808,8 @@ static int __devinit happy_meal_sbus_probe_one(struct platform_device *op, int i
happy_meal_set_initial_advertisement(hp);
spin_unlock_irq(&hp->happy_lock);
- if (register_netdev(hp->dev)) {
+ err = register_netdev(hp->dev);
+ if (err) {
printk(KERN_ERR "happymeal: Cannot register net device, "
"aborting.\n");
goto err_out_free_coherent;
@@ -3130,7 +3131,8 @@ static int __devinit happy_meal_pci_probe(struct pci_dev *pdev,
happy_meal_set_initial_advertisement(hp);
spin_unlock_irq(&hp->happy_lock);
- if (register_netdev(hp->dev)) {
+ err = register_netdev(hp->dev);
+ if (err) {
printk(KERN_ERR "happymeal(PCI): Cannot register net device, "
"aborting.\n");
goto err_out_iounmap;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sunhme: Use return value of register_netdev
2010-08-17 16:13 [PATCH] sunhme: Use return value of register_netdev Tobias Klauser
@ 2010-08-19 7:06 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-08-19 7:06 UTC (permalink / raw)
To: tklauser; +Cc: netdev, kernel-janitors
From: Tobias Klauser <tklauser@distanz.ch>
Date: Tue, 17 Aug 2010 18:13:05 +0200
> Use the return value provided by register_netdev on error instead of
> using a previously set value.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-19 7:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-17 16:13 [PATCH] sunhme: Use return value of register_netdev Tobias Klauser
2010-08-19 7:06 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).