From: David Miller <davem@davemloft.net>
To: jon.mason@exar.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org,
Ramkrishna.Vepa@exar.com, Sivakumar.Subramani@exar.com,
Sreenivasa.Honnur@exar.com
Subject: Re: [PATCH net-next-2.6] vxge: Implement 64bit stats
Date: Thu, 19 Aug 2010 00:17:10 -0700 (PDT) [thread overview]
Message-ID: <20100819.001710.137834207.davem@davemloft.net> (raw)
In-Reply-To: <20100818225330.GJ17009@exar.com>
From: Jon Mason <jon.mason@exar.com>
Date: Wed, 18 Aug 2010 17:53:31 -0500
> On Wed, Aug 18, 2010 at 06:42:54AM -0700, Eric Dumazet wrote:
>> vxge_get_stats() is racy, since it clears a block of memory (net_stats)
>> possibly still used by other cpus.
>>
>> We can update this driver to full 64bit stats, since ndo_get_stats64()
>> provides a private block to store results, and driver maintains 64bit
>> counters already.
>>
>> We also remove net_stats field from struct vxge_sw_stats
>>
>> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Acked-by: Jon Mason <jon.mason@exar.com>
Applied, thanks everyone.
prev parent reply other threads:[~2010-08-19 7:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 13:42 [PATCH net-next-2.6] vxge: Implement 64bit stats Eric Dumazet
2010-08-18 15:25 ` Jon Mason
2010-08-18 15:28 ` Eric Dumazet
2010-08-18 22:53 ` Jon Mason
2010-08-19 7:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100819.001710.137834207.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ramkrishna.Vepa@exar.com \
--cc=Sivakumar.Subramani@exar.com \
--cc=Sreenivasa.Honnur@exar.com \
--cc=eric.dumazet@gmail.com \
--cc=jon.mason@exar.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).