* [PATCH] vlan: Match underlying dev carrier on vlan add
@ 2010-08-18 4:45 Phil Oester
2010-08-19 7:27 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Phil Oester @ 2010-08-18 4:45 UTC (permalink / raw)
To: netdev
[-- Attachment #1: Type: text/plain, Size: 302 bytes --]
When adding a new vlan, if the underlying interface has no carrier,
then the newly added vlan interface should also have no carrier.
At present, this is not true - the newly added vlan is added with
carrier up. Fix by checking state of real device.
Signed-off-by: Phil Oester <kernel@linuxace.com>
[-- Attachment #2: patch-vlandev --]
[-- Type: text/plain, Size: 396 bytes --]
diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
index 3d59c9b..3bccdd1 100644
--- a/net/8021q/vlan_dev.c
+++ b/net/8021q/vlan_dev.c
@@ -510,7 +510,8 @@ static int vlan_dev_open(struct net_device *dev)
if (vlan->flags & VLAN_FLAG_GVRP)
vlan_gvrp_request_join(dev);
- netif_carrier_on(dev);
+ if (netif_carrier_ok(real_dev))
+ netif_carrier_on(dev);
return 0;
clear_allmulti:
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-19 7:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-18 4:45 [PATCH] vlan: Match underlying dev carrier on vlan add Phil Oester
2010-08-19 7:27 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).