netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] netxen: fix inconsistent lock state
@ 2010-08-18  6:51 Amit Kumar Salecha
  2010-08-18  6:51 ` [PATCH 2/2] netxen: update version 4.0.74 Amit Kumar Salecha
  2010-08-19  7:28 ` [PATCH 1/2] netxen: fix inconsistent lock state David Miller
  0 siblings, 2 replies; 4+ messages in thread
From: Amit Kumar Salecha @ 2010-08-18  6:51 UTC (permalink / raw)
  To: davem; +Cc: netdev, ameen.rahman

Spin lock rds_ring->lock is used in poll routine, so other users should
use spin_lock_bh(). While posting rx buffers from netxen_nic_attach,
rds_ring->lock is not required, so cleaning it instead of fixing it by
spin_lock_bh().

Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
---
 drivers/net/netxen/netxen_nic_init.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/net/netxen/netxen_nic_init.c b/drivers/net/netxen/netxen_nic_init.c
index c865dda..cabae7b 100644
--- a/drivers/net/netxen/netxen_nic_init.c
+++ b/drivers/net/netxen/netxen_nic_init.c
@@ -1805,8 +1805,6 @@ netxen_post_rx_buffers(struct netxen_adapter *adapter, u32 ringid,
 	netxen_ctx_msg msg = 0;
 	struct list_head *head;
 
-	spin_lock(&rds_ring->lock);
-
 	producer = rds_ring->producer;
 
 	head = &rds_ring->free_list;
@@ -1853,8 +1851,6 @@ netxen_post_rx_buffers(struct netxen_adapter *adapter, u32 ringid,
 					NETXEN_RCV_PRODUCER_OFFSET), msg);
 		}
 	}
-
-	spin_unlock(&rds_ring->lock);
 }
 
 static void
-- 
1.6.0.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-08-19  7:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-18  6:51 [PATCH 1/2] netxen: fix inconsistent lock state Amit Kumar Salecha
2010-08-18  6:51 ` [PATCH 2/2] netxen: update version 4.0.74 Amit Kumar Salecha
2010-08-19  7:28   ` David Miller
2010-08-19  7:28 ` [PATCH 1/2] netxen: fix inconsistent lock state David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).