From: David Miller <davem@davemloft.net>
To: fubar@us.ibm.com
Cc: eric.dumazet@gmail.com, brking@linux.vnet.ibm.com,
ossthema@de.ibm.com, osstklei@de.ibm.com, raisch@de.ibm.com,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] ehea: Allocate stats buffer with GFP_KERNEL
Date: Thu, 19 Aug 2010 00:53:23 -0700 (PDT) [thread overview]
Message-ID: <20100819.005323.73677219.davem@davemloft.net> (raw)
In-Reply-To: <29190.1282153781@death>
From: Jay Vosburgh <fubar@us.ibm.com>
Date: Wed, 18 Aug 2010 10:49:41 -0700
> So, the real question is whether the ndo_get_stats* functions
> are permitted to sleep. If they are, then bonding and netstat_show both
> need to change. If not, then ehea needs to change. Ehea is probably
> not alone in this; I poked around a bit, and it looks like mlx4 may also
> sleep in ndo_get_stats.
They really can't currently.... so EHEA will need to be changed
such that it can do stats fetching atomically.
In the long term, we could allow this.
The netstat_stat function should be RCU'able. And something
similar, I suppose, should be possible on the bonding side.
But as it stands EHEA has to be fixed and can't stay as-is.
prev parent reply other threads:[~2010-08-19 7:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 21:59 [PATCH 1/1] ehea: Allocate stats buffer with GFP_KERNEL Brian King
2010-07-02 5:48 ` David Miller
2010-08-18 14:10 ` Eric Dumazet
2010-08-18 17:49 ` Jay Vosburgh
2010-08-19 7:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100819.005323.73677219.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brking@linux.vnet.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ossthema@de.ibm.com \
--cc=osstklei@de.ibm.com \
--cc=raisch@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).