From: David Miller <davem@davemloft.net>
To: hadi@cyberus.ca
Cc: xiaosuo@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH 5/8] net_sched: cls_flow: use proto_ports_offset() to support AH message
Date: Thu, 19 Aug 2010 17:17:19 -0700 (PDT) [thread overview]
Message-ID: <20100819.171719.27791197.davem@davemloft.net> (raw)
In-Reply-To: <1282139589.23601.38.camel@bigi>
From: jamal <hadi@cyberus.ca>
Date: Wed, 18 Aug 2010 09:53:09 -0400
> On Wed, 2010-08-18 at 21:18 +0800, Changli Gao wrote:
>
>> I had gone through the code before submitting this code. But it isn't
>> easy to test if it breaks sth.
>
> That works well actually and it is the LinuxWay(tm);->
>
>> Would you please give a case to test ?
>
> Just conformance testing. Since you added new AH SPI behavior
> at least find some use case of what people normally use and make sure it
> isnt broken. But if youve looked at code sufficiently i think thats good
> enough.
I agree and I've applied his patch.
prev parent reply other threads:[~2010-08-20 0:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 5:05 [PATCH 5/8] net_sched: cls_flow: use proto_ports_offset() to support AH message Changli Gao
2010-08-18 11:02 ` jamal
2010-08-18 12:42 ` Changli Gao
2010-08-18 12:54 ` jamal
2010-08-18 13:18 ` Changli Gao
2010-08-18 13:53 ` jamal
2010-08-20 0:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100819.171719.27791197.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).