From: David Miller <davem@davemloft.net>
To: ron.mercer@qlogic.com
Cc: error27@gmail.com, Linux-Driver@qlogic.com,
leitao@linux.vnet.ibm.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] qlge: pull NULL check ahead of dereference
Date: Thu, 19 Aug 2010 20:48:18 -0700 (PDT) [thread overview]
Message-ID: <20100819.204818.13765444.davem@davemloft.net> (raw)
In-Reply-To: <20100819202836.GD17233@linux-ox1b.qlogic.org>
From: Ron Mercer <ron.mercer@qlogic.com>
Date: Thu, 19 Aug 2010 13:28:36 -0700
> On Thu, Aug 19, 2010 at 11:52:44AM -0700, Dan Carpenter wrote:
>> There was a dereference before NULL check issue introduced in 1e213303d
>> "qlge: Add tx multiqueue support." I've pulled the NULL check of
>> "net_rsp" forward a couple lines to avoid that.
>>
>> Also Ron Mercer says that the early exit should be above the index
>> write. ql_write_cq_idx(rx_ring);
>>
>
> Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>
Applied to net-next-2.6, thanks guys.
prev parent reply other threads:[~2010-08-20 3:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 10:02 [patch] qlge: pull NULL check ahead of dereference Dan Carpenter
2010-08-19 12:19 ` Ron Mercer
2010-08-19 12:59 ` Ron Mercer
2010-08-19 18:52 ` [patch v2] " Dan Carpenter
2010-08-19 20:28 ` Ron Mercer
2010-08-20 3:48 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100819.204818.13765444.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Linux-Driver@qlogic.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=leitao@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).