From: Tobias Klauser <tklauser@distanz.ch>
To: David Miller <davem@davemloft.net>
Cc: shemminger@vyatta.com, linux@arm.linux.org.uk,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kernel-janitors@vger.kernel.org, error27@gmail.com
Subject: Re: [PATCH v2] ether1: Use net_device_stats from struct net_device
Date: Thu, 19 Aug 2010 08:14:31 +0200 [thread overview]
Message-ID: <20100819061431.GA20793@distanz.ch> (raw)
In-Reply-To: <20100818.131043.226780154.davem@davemloft.net>
On 2010-08-18 at 22:10:43 +0200, David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <shemminger@vyatta.com>
> Date: Wed, 18 Aug 2010 08:33:04 -0700
>
> > On Wed, 18 Aug 2010 09:04:24 +0200
> > Tobias Klauser <tklauser@distanz.ch> wrote:
> >
> >>
> >> - memset (&priv(dev)->stats, 0, sizeof (struct net_device_stats));
> >> + memset(&dev->stats, 0, sizeof(struct net_device_stats));
> >
> > This is incorrect, just remove the memset. The stats are initialized
> > when device is created. The Linux device driver convention is to
> > keep stats when device is set down and brought back up; that is what
> > the majority of other drivers do.
>
> Yep, both the ether1 and ether3 patch have this problem. Looks
> like we'll see v4 coming some :-)
Thanks a lot. I'll send another updated patch. Hope I get it right this
time :-)
AFAICS there are a few other network drivers having the same problem,
I'll send patches for those too.
next prev parent reply other threads:[~2010-08-19 6:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 16:15 [PATCH] ether1: Use net_device_stats from struct net_device Tobias Klauser
2010-08-17 18:32 ` Dan Carpenter
2010-08-17 18:34 ` Tobias Klauser
2010-08-18 7:04 ` [PATCH v2] " Tobias Klauser
2010-08-18 8:13 ` Russell King - ARM Linux
2010-08-18 8:27 ` Eric Dumazet
2010-08-18 8:33 ` Tobias Klauser
2010-08-18 15:33 ` Stephen Hemminger
2010-08-18 20:10 ` David Miller
2010-08-18 20:44 ` [PATCH net-next-2.6] atm: remove a net_device_stats clear Eric Dumazet
2010-08-19 7:15 ` David Miller
2010-08-19 6:14 ` Tobias Klauser [this message]
2010-08-18 8:45 ` [PATCH v3] ether1: Use net_device_stats from struct net_device Tobias Klauser
2010-08-19 6:15 ` [PATCH v4] " Tobias Klauser
2010-08-19 7:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100819061431.GA20793@distanz.ch \
--to=tklauser@distanz.ch \
--cc=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).