From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Changli Gao <xiaosuo@gmail.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next-2.6] net: build_ehash_secret() and rt_bind_peer() cleanups
Date: Thu, 19 Aug 2010 12:30:22 -0400 [thread overview]
Message-ID: <20100819163022.GD24357@Krystal> (raw)
In-Reply-To: <20100819161326.GB24357@Krystal>
* Mathieu Desnoyers (mathieu.desnoyers@polymtl.ca) wrote:
> * Changli Gao (xiaosuo@gmail.com) wrote:
> > On Thu, Aug 19, 2010 at 11:46 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
[...]
> > > + peer = cmpxchg(&rt->peer, NULL, peer);
> > > +
> > > + if (unlikely(peer))
> >
> > It isn't correct, and should be
> > if (unlikely(cmpxchg(&rt->peer, NULL, peer) != NULL))
> >
> > > inet_putpeer(peer);
> > > }
>
> What do you mean by "It isn't correct" ? Eric code and yours perform the
> exact same thing. So I assume this is just a code style issue here.
Nevermind my comment, it's not accurate.
Thanks,
Mathieu
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2010-08-19 16:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 15:46 [PATCH net-next-2.6] net: build_ehash_secret() and rt_bind_peer() cleanups Eric Dumazet
2010-08-19 15:58 ` Changli Gao
2010-08-19 16:10 ` [PATCH net-next-2.6 v2] " Eric Dumazet
2010-08-20 7:51 ` David Miller
2010-08-19 16:10 ` [PATCH net-next-2.6] " Changli Gao
2010-08-19 16:13 ` Mathieu Desnoyers
2010-08-19 16:30 ` Mathieu Desnoyers [this message]
2010-08-19 16:28 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100819163022.GD24357@Krystal \
--to=mathieu.desnoyers@polymtl.ca \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).