From: Jarek Poplawski <jarkao2@gmail.com>
To: Plamen Petrov <pvp-lsts@fs.uni-ruse.bg>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org, bugzilla-daemon@bugzilla.kernel.org,
bugme-daemon@bugzilla.kernel.org
Subject: Re: [Bugme-new] [Bug 16626] New: Machine hangs with EIP at skb_copy_and_csum_dev
Date: Fri, 20 Aug 2010 21:38:35 +0200 [thread overview]
Message-ID: <20100820193835.GA6025@del.dom.local> (raw)
In-Reply-To: <4C6E5EA7.3040609@fs.uni-ruse.bg>
Plamen Petrov wrote, On 20.08.2010 12:53:
> So, I guess its David and Herbert's turn?...
If you're bored in the meantime I'd suggest to do check the realtek
driver eg:
- for locking with the patch below,
- to turn off with ethtool its tx-checksumming and/or scatter-gather,
or if possible try to reproduce this with other NIC.
Thanks,
Jarek P.
---
diff --git a/drivers/net/8139too.c b/drivers/net/8139too.c
index f5166dc..aaaccc5 100644
--- a/drivers/net/8139too.c
+++ b/drivers/net/8139too.c
@@ -1692,6 +1692,8 @@ static netdev_tx_t rtl8139_start_xmit (struct sk_buff *skb,
unsigned int len = skb->len;
unsigned long flags;
+ spin_lock_irqsave(&tp->lock, flags);
+
/* Calculate the next Tx descriptor entry. */
entry = tp->cur_tx % NUM_TX_DESC;
@@ -1700,14 +1702,14 @@ static netdev_tx_t rtl8139_start_xmit (struct sk_buff *skb,
if (len < ETH_ZLEN)
memset(tp->tx_buf[entry], 0, ETH_ZLEN);
skb_copy_and_csum_dev(skb, tp->tx_buf[entry]);
- dev_kfree_skb(skb);
+ dev_kfree_skb_irq(skb);
} else {
+ spin_unlock_irqrestore(&tp->lock, flags);
dev_kfree_skb(skb);
dev->stats.tx_dropped++;
return NETDEV_TX_OK;
}
- spin_lock_irqsave(&tp->lock, flags);
/*
* Writing to TxStatus triggers a DMA transfer of the data
* copied to tp->tx_buf[entry] above. Use a memory barrier
next prev parent reply other threads:[~2010-08-20 19:38 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-16626-10286@https.bugzilla.kernel.org/>
2010-08-19 22:21 ` [Bugme-new] [Bug 16626] New: Machine hangs with EIP at skb_copy_and_csum_dev Andrew Morton
2010-08-20 5:03 ` Plamen Petrov
2010-08-20 5:11 ` Andrew Morton
2010-08-20 6:12 ` Plamen Petrov
2010-08-20 6:20 ` Andrew Morton
2010-08-20 6:26 ` Plamen Petrov
2010-08-20 6:34 ` Eric Dumazet
2010-08-20 6:57 ` Plamen Petrov
2010-08-20 7:38 ` Plamen Petrov
2010-08-20 8:31 ` Plamen Petrov
2010-08-20 9:19 ` Plamen Petrov
2010-08-20 10:26 ` Eric Dumazet
2010-08-20 10:53 ` Plamen Petrov
2010-08-20 19:38 ` Jarek Poplawski [this message]
2010-08-21 7:47 ` Jarek Poplawski
2010-08-21 7:50 ` Eric Dumazet
2010-08-21 8:07 ` Jarek Poplawski
2010-08-23 11:47 ` Plamen Petrov
2010-08-23 12:35 ` Eric Dumazet
2010-08-23 12:47 ` Jarek Poplawski
2010-08-23 13:00 ` Eric Dumazet
2010-08-23 13:10 ` Jarek Poplawski
2010-08-23 13:43 ` Plamen Petrov
2010-08-23 14:05 ` Plamen Petrov
2010-08-23 14:14 ` Jarek Poplawski
2010-08-24 4:51 ` Plamen Petrov
2010-08-24 5:01 ` Eric Dumazet
2010-08-24 8:43 ` Plamen Petrov
2010-08-24 13:27 ` Plamen Petrov
2010-08-24 15:08 ` Eric Dumazet
2010-08-24 17:25 ` Plamen Petrov
2010-08-24 18:22 ` Jarek Poplawski
2010-08-24 19:19 ` Eric Dumazet
2010-08-25 7:05 ` Plamen Petrov
2010-08-29 7:48 ` [PATCH] net: reset ip_summed in skb_tunnel_rx() Eric Dumazet
2010-08-29 15:35 ` Jesse Gross
2010-08-27 8:44 ` [Bugme-new] [Bug 16626] New: Machine hangs with EIP at skb_copy_and_csum_dev Plamen Petrov
2010-08-24 5:19 ` Plamen Petrov
2010-08-24 6:18 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100820193835.GA6025@del.dom.local \
--to=jarkao2@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pvp-lsts@fs.uni-ruse.bg \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).