From: David Miller <davem@davemloft.net>
To: xiaosuo@gmail.com
Cc: arnd@arndb.de, eric.dumazet@gmail.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: define __packed for the userspace code
Date: Sun, 22 Aug 2010 21:16:05 -0700 (PDT) [thread overview]
Message-ID: <20100822.211605.02288279.davem@davemloft.net> (raw)
In-Reply-To: <20100822.193609.35028164.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Sun, 22 Aug 2010 19:36:09 -0700 (PDT)
> From: Changli Gao <xiaosuo@gmail.com>
> Date: Mon, 23 Aug 2010 10:29:49 +0800
>
>> Do you mean that use the __attribute__((packed)) annotation in all of
>> these files:
>>
>> localhost linux # grep "\<__packed\>" usr/include/ -r | uniq
>> usr/include/linux/if_hippi.h:} __packed;
>> usr/include/linux/if_fddi.h:} __packed;
>> usr/include/linux/nbd.h:} __packed;
>> usr/include/linux/ncp.h:} __packed;
>> usr/include/linux/rfkill.h:} __packed;
>> usr/include/linux/if_pppox.h:} __packed;
>> usr/include/linux/phonet.h:} __packed;
>> usr/include/linux/ipv6.h:} __packed; /* required for some archs */
>> usr/include/linux/ipv6.h:} __packed;
>> usr/include/linux/if_ether.h:} __packed;
>
> It seems so, yes.
Changli I applied your patch to convert these __packed tags back to
the original expansion.
Thanks!
prev parent reply other threads:[~2010-08-23 4:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-22 11:12 [PATCH] net: define __packed for the userspace code Changli Gao
2010-08-22 11:23 ` Changli Gao
2010-08-22 13:07 ` Arnd Bergmann
2010-08-22 13:47 ` Changli Gao
2010-08-23 1:36 ` David Miller
2010-08-23 2:29 ` Changli Gao
2010-08-23 2:36 ` David Miller
2010-08-23 4:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100822.211605.02288279.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).