* [PATCH -next] isdn/avm: fix build when PCMCIA is not enabled
[not found] <20100819143941.d3ea5cb4.sfr@canb.auug.org.au>
@ 2010-08-19 17:07 ` Randy Dunlap
2010-08-23 4:37 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2010-08-19 17:07 UTC (permalink / raw)
To: Stephen Rothwell, Carsten Paeth, Karsten Keil; +Cc: linux-next, LKML, netdev
From: Randy Dunlap <randy.dunlap@oracle.com>
Why wouldn't kconfig symbol ISDN_DRV_AVMB1_B1PCMCIA also depend on
PCMCIA?
Fix build for PCMCIA not enabled:
ERROR: "b1_free_card" [drivers/isdn/hardware/avm/b1pcmcia.ko] undefined!
ERROR: "b1ctl_proc_fops" [drivers/isdn/hardware/avm/b1pcmcia.ko] undefined!
ERROR: "b1_reset_ctr" [drivers/isdn/hardware/avm/b1pcmcia.ko] undefined!
ERROR: "b1_load_firmware" [drivers/isdn/hardware/avm/b1pcmcia.ko] undefined!
ERROR: "b1_send_message" [drivers/isdn/hardware/avm/b1pcmcia.ko] undefined!
ERROR: "b1_release_appl" [drivers/isdn/hardware/avm/b1pcmcia.ko] undefined!
ERROR: "b1_register_appl" [drivers/isdn/hardware/avm/b1pcmcia.ko] undefined!
ERROR: "b1_getrevision" [drivers/isdn/hardware/avm/b1pcmcia.ko] undefined!
ERROR: "b1_detect" [drivers/isdn/hardware/avm/b1pcmcia.ko] undefined!
ERROR: "b1_interrupt" [drivers/isdn/hardware/avm/b1pcmcia.ko] undefined!
ERROR: "b1_alloc_card" [drivers/isdn/hardware/avm/b1pcmcia.ko] undefined!
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Carsten Paeth <calle@calle.de>
Cc: Karsten Keil <isdn@linux-pingi.de>
---
drivers/isdn/hardware/avm/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-next-20100819.orig/drivers/isdn/hardware/avm/Kconfig
+++ linux-next-20100819/drivers/isdn/hardware/avm/Kconfig
@@ -36,12 +36,13 @@ config ISDN_DRV_AVMB1_T1ISA
config ISDN_DRV_AVMB1_B1PCMCIA
tristate "AVM B1/M1/M2 PCMCIA support"
+ depends on PCMCIA
help
Enable support for the PCMCIA version of the AVM B1 card.
config ISDN_DRV_AVMB1_AVM_CS
tristate "AVM B1/M1/M2 PCMCIA cs module"
- depends on ISDN_DRV_AVMB1_B1PCMCIA && PCMCIA
+ depends on ISDN_DRV_AVMB1_B1PCMCIA
help
Enable the PCMCIA client driver for the AVM B1/M1/M2
PCMCIA cards.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] isdn/avm: fix build when PCMCIA is not enabled
2010-08-19 17:07 ` [PATCH -next] isdn/avm: fix build when PCMCIA is not enabled Randy Dunlap
@ 2010-08-23 4:37 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-08-23 4:37 UTC (permalink / raw)
To: randy.dunlap; +Cc: sfr, calle, isdn, linux-next, linux-kernel, netdev
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Thu, 19 Aug 2010 10:07:23 -0700
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Why wouldn't kconfig symbol ISDN_DRV_AVMB1_B1PCMCIA also depend on
> PCMCIA?
>
> Fix build for PCMCIA not enabled:
...
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Applied to net-2.6, thanks Randy.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-23 4:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20100819143941.d3ea5cb4.sfr@canb.auug.org.au>
2010-08-19 17:07 ` [PATCH -next] isdn/avm: fix build when PCMCIA is not enabled Randy Dunlap
2010-08-23 4:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).