From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver Date: Mon, 23 Aug 2010 20:35:52 -0700 (PDT) Message-ID: <20100823.203552.63040549.davem@davemloft.net> References: <201008232123.o7NLNOpc032761@blc-10-10.brocade.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, amathur@brocade.com, ddutt@brocade.com, huangj@brocade.com To: rmody@brocade.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:33005 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751708Ab0HXDfe (ORCPT ); Mon, 23 Aug 2010 23:35:34 -0400 In-Reply-To: <201008232123.o7NLNOpc032761@blc-10-10.brocade.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Rasesh Mody Date: Mon, 23 Aug 2010 14:23:24 -0700 > From: Rasesh Mody > > This is patch 0/6 which contains the summary of changes we've > done in this particular submission for Brocade's BR1010/BR1020 > 10Gb CEE capable ethernet adapter. Source is based against > net-next-2.6. > > The changes are as follows: > > - Removed unused variables and misc cleanup > > We wish these patches to be considered for inclusion in net-next-2.6. > > Signed-off-by: Debashis Dutt > Signed-off-by: Rasesh Mody Applied to net-next-2.6, but I had to apply the following bug fix. Do you even look at the warnings generated by the build of the code you submit? -------------------- bna: Delete get_flags and set_flags ethtool methods. This driver doesn't support LRO, NTUPLE, or the RXHASH features. So it should not set these ethtool operations. This also fixes the warning: drivers/net/bna/bnad_ethtool.c:1272: warning: initialization from incompatible pointer type Signed-off-by: David S. Miller --- drivers/net/bna/bnad_ethtool.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/bna/bnad_ethtool.c b/drivers/net/bna/bnad_ethtool.c index e982785..7e630f5 100644 --- a/drivers/net/bna/bnad_ethtool.c +++ b/drivers/net/bna/bnad_ethtool.c @@ -1268,8 +1268,6 @@ static struct ethtool_ops bnad_ethtool_ops = { .set_sg = ethtool_op_set_sg, .get_tso = ethtool_op_get_tso, .set_tso = bnad_set_tso, - .get_flags = ethtool_op_get_flags, - .set_flags = ethtool_op_set_flags, .get_strings = bnad_get_strings, .get_ethtool_stats = bnad_get_ethtool_stats, .get_sset_count = bnad_get_sset_count -- 1.7.2.2