From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] net: copy_rtnl_link_stats64() simplification
Date: Mon, 23 Aug 2010 20:45:07 -0700 (PDT) [thread overview]
Message-ID: <20100823.204507.26936954.davem@davemloft.net> (raw)
In-Reply-To: <1282584096.2267.34.camel@achroite.uk.solarflarecom.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 23 Aug 2010 18:21:36 +0100
> On Mon, 2010-08-23 at 19:14 +0200, Eric Dumazet wrote:
>> No need to use a temporary struct rtnl_link_stats64 variable,
>> just copy the source to skb buffer.
>
> Yes, this makes sense.
>
> The reason I didn't do this initially was that I was concerned about
> possible tearing of asynchronously-updated stats. Since you made
> dev_get_stats() copy into a caller-provided buffer, this is no longer a
> concern.
>
> For what it's worth:
>
>> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Reviewed-by: Ben Hutchings <bhutchings@solarflare.com>
Applied, thanks.
next prev parent reply other threads:[~2010-08-24 3:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 17:14 [PATCH net-next-2.6] net: copy_rtnl_link_stats64() simplification Eric Dumazet
2010-08-23 17:21 ` Ben Hutchings
2010-08-24 3:45 ` David Miller [this message]
2010-08-23 17:47 ` Joe Perches
2010-08-23 18:14 ` Ben Hutchings
2010-08-24 3:44 ` David Miller
2010-08-23 18:17 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100823.204507.26936954.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).