netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Ulrich Weber <uweber@astaro.com>
Cc: Andreas Henriksson <andreas@fatal.se>,
	Fabio Comolli <fabio.comolli@gmail.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH] iproute2: dont filter cached routes on iproute_get
Date: Mon, 23 Aug 2010 08:15:22 -0700	[thread overview]
Message-ID: <20100823081522.3fa7eff9@nehalam> (raw)
In-Reply-To: <20100812090519.GA13769@babylon>

On Thu, 12 Aug 2010 11:05:19 +0200
Ulrich Weber <uweber@astaro.com> wrote:

> iproute_get will return cloned routes for IPv4
> and cloned as well non-cloned routes for IPv6.
> 
> Therefore RTM_F_CLONED flag should not be checked
> for iproute_get routes. Check in print_route will
> always fail because valid values are 0 and 1.
> 
> Signed-off-by: Ulrich Weber <uweber@astaro.com>
> ---
>  ip/iproute.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/ip/iproute.c b/ip/iproute.c
> index 711576e..b43933c 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -1286,6 +1286,7 @@ int iproute_get(int argc, char **argv)
>  	memset(&req, 0, sizeof(req));
>  
>  	iproute_reset_filter();
> +	filter.cloned = 2;
>  
>  	req.n.nlmsg_len = NLMSG_LENGTH(sizeof(struct rtmsg));
>  	req.n.nlmsg_flags = NLM_F_REQUEST;

Applied

-- 

      parent reply	other threads:[~2010-08-23 15:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-08 19:33 Latest iproute2 breaks "ip route get" command Andreas Henriksson
2010-08-08 19:31 ` Fabio Comolli
2010-08-08 19:52   ` Andreas Henriksson
2010-08-12  9:02     ` Ulrich Weber
2010-08-12  9:05     ` [PATCH] iproute2: dont filter cached routes on iproute_get Ulrich Weber
2010-08-12  9:12       ` Fabio Comolli
2010-08-12  9:20         ` Ulrich Weber
2010-08-12 18:58           ` Fabio Comolli
2010-08-23 15:15       ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100823081522.3fa7eff9@nehalam \
    --to=shemminger@vyatta.com \
    --cc=andreas@fatal.se \
    --cc=fabio.comolli@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=uweber@astaro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).