From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] iproute2: dont filter cached routes on iproute_get Date: Mon, 23 Aug 2010 08:15:22 -0700 Message-ID: <20100823081522.3fa7eff9@nehalam> References: <20100808193304.GA15380@amd64.fatal.se> <1281297165.4116.19.camel@amd64.fatal.se> <20100812090519.GA13769@babylon> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Andreas Henriksson , Fabio Comolli , netdev@vger.kernel.org To: Ulrich Weber Return-path: Received: from mail.vyatta.com ([76.74.103.46]:60193 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753268Ab0HWPPZ (ORCPT ); Mon, 23 Aug 2010 11:15:25 -0400 In-Reply-To: <20100812090519.GA13769@babylon> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 12 Aug 2010 11:05:19 +0200 Ulrich Weber wrote: > iproute_get will return cloned routes for IPv4 > and cloned as well non-cloned routes for IPv6. > > Therefore RTM_F_CLONED flag should not be checked > for iproute_get routes. Check in print_route will > always fail because valid values are 0 and 1. > > Signed-off-by: Ulrich Weber > --- > ip/iproute.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/ip/iproute.c b/ip/iproute.c > index 711576e..b43933c 100644 > --- a/ip/iproute.c > +++ b/ip/iproute.c > @@ -1286,6 +1286,7 @@ int iproute_get(int argc, char **argv) > memset(&req, 0, sizeof(req)); > > iproute_reset_filter(); > + filter.cloned = 2; > > req.n.nlmsg_len = NLMSG_LENGTH(sizeof(struct rtmsg)); > req.n.nlmsg_flags = NLM_F_REQUEST; Applied --