From: Stephen Hemminger <shemminger@vyatta.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] iproute2: add 64bit support to ifstat
Date: Mon, 23 Aug 2010 13:39:49 -0700 [thread overview]
Message-ID: <20100823133949.3e160d07@nehalam> (raw)
In-Reply-To: <1282595311.2378.288.camel@edumazet-laptop>
On Mon, 23 Aug 2010 22:28:31 +0200
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Le lundi 23 août 2010 à 13:06 -0700, Stephen Hemminger a écrit :
> > > @@ -563,8 +563,6 @@ static void usage(void)
> > > " -s, --noupdate don;t update history\n"
> > > " -t, --interval=SECS report average over the last SECS\n"
> > > " -V, --version output version information\n"
> > > -" -z, --zeros show entries with zero activity\n"
> > > -" -e, --errors show errors\n"
> > > " -z, --zeros show entries with zero activity\n");
> > >
> > > exit(-1);
> > > @@ -581,8 +579,6 @@ static const struct option longopts[] = {
> > > { "interval", 1, 0, 't' },
> > > { "version", 0, 0, 'V' },
> > > { "zeros", 0, 0, 'z' },
> > > - { "errors", 0, 0, 'e' },
> > > - { "zeros", 0, 0, 'z' },
> > > { 0 }
> > > };
> > >
> > >
> > >
> >
> > Did you mean to break --errors?
>
> I dont think so.
>
> These options are already handled, unless I am wrong.
>
> Do you want a separate patch for this trivial fix ?
I'll tweak your previous patch
--
prev parent reply other threads:[~2010-08-23 20:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 15:32 [PATCH] netdev: re-expose net_device_stats to user headers Stephen Hemminger
2010-08-23 15:43 ` Ben Hutchings
2010-08-23 16:17 ` Stephen Hemminger
2010-08-23 16:54 ` [PATCH] iproute2: add 64bit support to ifstat Eric Dumazet
2010-08-23 17:33 ` Stephen Hemminger
2010-08-23 19:44 ` Eric Dumazet
2010-08-23 20:06 ` Stephen Hemminger
2010-08-23 20:28 ` Eric Dumazet
2010-08-23 20:39 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100823133949.3e160d07@nehalam \
--to=shemminger@vyatta.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).