From: Hagen Paul Pfeifer <hagen@jauu.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
"Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Subject: Re: [PATCH] tcp: make TCP quick ACK behavior modifiable
Date: Mon, 23 Aug 2010 22:49:20 +0200 [thread overview]
Message-ID: <20100823204920.GC5896@nuttenaction> (raw)
In-Reply-To: <1282596243.2378.327.camel@edumazet-laptop>
* Eric Dumazet | 2010-08-23 22:44:03 [+0200]:
>> static inline void inet_csk_delack_init(struct sock *sk)
>> {
>> memset(&inet_csk(sk)->icsk_ack, 0, sizeof(inet_csk(sk)->icsk_ack));
>> + inet_csk(sk)->icsk_ack.pingpong = sysctl_tcp_quickack ? 0 : 1;
>
>What about dccp using this function ?
I will check this and re-spin the patch if necessary. Thank you Eric, I missed
DCCP.
>So here is a new undocumented setting ? hint hint...
>
>I thought setsockopt(TCP_QUICKACK) was already available for this
>optimization ?
... and it is still available. ;-) See my other post answering Stephen's email.
Hagen
next prev parent reply other threads:[~2010-08-23 20:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 19:00 [PATCH] tcp: make TCP quick ACK behavior modifiable Hagen Paul Pfeifer
2010-08-23 19:14 ` Stephen Hemminger
2010-08-23 19:57 ` Hagen Paul Pfeifer
2010-08-23 20:08 ` Hagen Paul Pfeifer
2010-08-23 21:21 ` David Miller
2010-08-23 21:51 ` Hagen Paul Pfeifer
2010-08-23 22:04 ` Chris Snook
2010-08-23 22:16 ` David Miller
2010-08-23 20:44 ` Eric Dumazet
2010-08-23 20:49 ` Hagen Paul Pfeifer [this message]
2010-08-23 21:10 ` Chris Snook
2010-08-23 22:01 ` Hagen Paul Pfeifer
2010-08-23 22:19 ` Chris Snook
2010-08-23 22:23 ` David Miller
2010-08-23 22:26 ` Hagen Paul Pfeifer
2010-08-23 23:17 ` Arnaldo Carvalho de Melo
2010-08-23 23:18 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100823204920.GC5896@nuttenaction \
--to=hagen@jauu.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).