* [patch 4/4] pxa168_eth: silence gcc warnings
@ 2010-08-24 16:55 Dan Carpenter
2010-08-24 21:51 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2010-08-24 16:55 UTC (permalink / raw)
To: Sachin Sanap; +Cc: David S. Miller, netdev, kernel-janitors
Casting "pep->tx_desc_dma" to to a struct tx_desc pointer makes gcc
complain:
drivers/net/pxa168_eth.c:657: warning:
cast to pointer from integer of different size
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/pxa168_eth.c b/drivers/net/pxa168_eth.c
index f324b76..b1f440b 100644
--- a/drivers/net/pxa168_eth.c
+++ b/drivers/net/pxa168_eth.c
@@ -654,15 +654,15 @@ static void eth_port_start(struct net_device *dev)
/* Assignment of Tx CTRP of given queue */
tx_curr_desc = pep->tx_curr_desc_q;
wrl(pep, ETH_C_TX_DESC_1,
- (u32) ((struct tx_desc *)pep->tx_desc_dma + tx_curr_desc));
+ (u32) (pep->tx_desc_dma + tx_curr_desc * sizeof(struct tx_desc)));
/* Assignment of Rx CRDP of given queue */
rx_curr_desc = pep->rx_curr_desc_q;
wrl(pep, ETH_C_RX_DESC_0,
- (u32) ((struct rx_desc *)pep->rx_desc_dma + rx_curr_desc));
+ (u32) (pep->rx_desc_dma + rx_curr_desc * sizeof(struct rx_desc)));
wrl(pep, ETH_F_RX_DESC_0,
- (u32) ((struct rx_desc *)pep->rx_desc_dma + rx_curr_desc));
+ (u32) (pep->rx_desc_dma + rx_curr_desc * sizeof(struct rx_desc)));
/* Clear all interrupts */
wrl(pep, INT_CAUSE, 0);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch 4/4] pxa168_eth: silence gcc warnings
2010-08-24 16:55 [patch 4/4] pxa168_eth: silence gcc warnings Dan Carpenter
@ 2010-08-24 21:51 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-08-24 21:51 UTC (permalink / raw)
To: error27; +Cc: ssanap, netdev, kernel-janitors
From: Dan Carpenter <error27@gmail.com>
Date: Tue, 24 Aug 2010 18:55:05 +0200
> Casting "pep->tx_desc_dma" to to a struct tx_desc pointer makes gcc
> complain:
>
> drivers/net/pxa168_eth.c:657: warning:
> cast to pointer from integer of different size
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-24 21:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-24 16:55 [patch 4/4] pxa168_eth: silence gcc warnings Dan Carpenter
2010-08-24 21:51 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).