From: David Miller <davem@davemloft.net>
To: rmody@brocade.com
Cc: netdev@vger.kernel.org, amathur@brocade.com, ddutt@brocade.com,
huangj@brocade.com
Subject: Re: [net-next-2.6 1/1]: bna: Fix build break for allyesconfig
Date: Wed, 25 Aug 2010 15:22:43 -0700 (PDT) [thread overview]
Message-ID: <20100825.152243.260093985.davem@davemloft.net> (raw)
In-Reply-To: <201008252132.o7PLWA0j029512@blc-10-10.brocade.com>
From: Rasesh Mody <rmody@brocade.com>
Date: Wed, 25 Aug 2010 14:32:10 -0700
> From: Rasesh Mody <rmody@brocade.com>
>
> This patch contains a fix for the build break caused by multiple
> definitions of symbols between Brocade's FC/FCOE driver(BFA)
> and 10G Networking Driver(BNA).
>
> The fix is to make BNA a module only driver.
>
> Signed-off-by: Debashis Dutt <ddutt@brocade.com>
> Signed-off-by: Rasesh Mody <rmody@brocade.com>
You have to be kidding me. This fix is totally unacceptable.
You have to go through your two drivers and:
1) Mark as 'static' symbols that don't actually need global
visibility.
2) Make the two drivers use unique namespaces for the function
names that must be globally visible for whatever reason.
You are really trying my patience, fix this properly and promptly
or I'm removing your driver from the tree.
next prev parent reply other threads:[~2010-08-25 22:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 21:32 [net-next-2.6 1/1]: bna: Fix build break for allyesconfig Rasesh Mody
2010-08-25 21:52 ` Eric Dumazet
2010-08-25 22:22 ` David Miller [this message]
2010-08-25 23:05 ` Rasesh Mody
2010-08-25 23:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100825.152243.260093985.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amathur@brocade.com \
--cc=ddutt@brocade.com \
--cc=huangj@brocade.com \
--cc=netdev@vger.kernel.org \
--cc=rmody@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).