From: David Miller <davem@davemloft.net>
To: rmody@brocade.com
Cc: netdev@vger.kernel.org, amathur@brocade.com, ddutt@Brocade.COM,
huangj@Brocade.COM
Subject: Re: [net-next-2.6 1/1]: bna: Fix build break for allyesconfig
Date: Wed, 25 Aug 2010 16:25:35 -0700 (PDT) [thread overview]
Message-ID: <20100825.162535.102560853.davem@davemloft.net> (raw)
In-Reply-To: <E5313AF6F2BFD14293E5FD0F94750F86A4AE226112@HQ1-EXCH01.corp.brocade.com>
From: Rasesh Mody <rmody@brocade.com>
Date: Wed, 25 Aug 2010 16:05:43 -0700
> We are working on fixing it properly. We will submit the patches as
> soon as possible.
Thank you.
Also, if this is essentially two copies of the same piece of code,
consider splitting it out into a seperate module in the future. There
are a few drivers which do this, f.e. see the MLX4 driver, which
supports both a network device and an infiniband device out of the
same hardware, using a core of shared code in a seperate module called
mlx4_core which exports symbols to the network and infiniband drivers.
prev parent reply other threads:[~2010-08-25 23:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 21:32 [net-next-2.6 1/1]: bna: Fix build break for allyesconfig Rasesh Mody
2010-08-25 21:52 ` Eric Dumazet
2010-08-25 22:22 ` David Miller
2010-08-25 23:05 ` Rasesh Mody
2010-08-25 23:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100825.162535.102560853.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amathur@brocade.com \
--cc=ddutt@Brocade.COM \
--cc=huangj@Brocade.COM \
--cc=netdev@vger.kernel.org \
--cc=rmody@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).