[net-next-2.6 1/1]: bna: Fix build break for allyesconfig

[net-next-2.6 1/1]: bna: Fix build break for allyesconfig

[Rasesh Mody]

From: Rasesh Mody <rmody@brocade.com>

This patch contains a fix for the build break caused by multiple
definitions of symbols between Brocade's FC/FCOE driver(BFA) 
and 10G Networking Driver(BNA).

The fix is to make BNA a module only driver.

Signed-off-by: Debashis Dutt <ddutt@brocade.com>
Signed-off-by: Rasesh Mody <rmody@brocade.com>
---
 Kconfig |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -ruP net-next-2.6.36-rc1-orig/drivers/net/Kconfig net-next-2.6.36-rc1-mod/drivers/net/Kconfig
--- net-next-2.6.36-rc1-orig/drivers/net/Kconfig	2010-08-25 00:59:00.000000000 -0700
+++ net-next-2.6.36-rc1-mod/drivers/net/Kconfig	2010-08-25 14:24:54.236217000 -0700
@@ -2871,7 +2871,7 @@
 
 config BNA
         tristate "Brocade 1010/1020 10Gb Ethernet Driver support"
-        depends on PCI
+        depends on PCI && m
         ---help---
           This driver supports Brocade 1010/1020 10Gb CEE capable Ethernet
           cards.

Re: [net-next-2.6 1/1]: bna: Fix build break for allyesconfig

[Eric Dumazet]

Le mercredi 25 août 2010 à 14:32 -0700, Rasesh Mody a écrit :
> From: Rasesh Mody <rmody@brocade.com>
> 
> This patch contains a fix for the build break caused by multiple
> definitions of symbols between Brocade's FC/FCOE driver(BFA) 
> and 10G Networking Driver(BNA).
> 
> The fix is to make BNA a module only driver.
> 
> Signed-off-by: Debashis Dutt <ddutt@brocade.com>
> Signed-off-by: Rasesh Mody <rmody@brocade.com>
> ---
>  Kconfig |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 

small note about diffstat : please use -p1 -w70 options for next
submissions. 

I wont comment on the patch itself.

Re: [net-next-2.6 1/1]: bna: Fix build break for allyesconfig

[David Miller]

From: Rasesh Mody <rmody@brocade.com>
Date: Wed, 25 Aug 2010 14:32:10 -0700

> From: Rasesh Mody <rmody@brocade.com>
> 
> This patch contains a fix for the build break caused by multiple
> definitions of symbols between Brocade's FC/FCOE driver(BFA) 
> and 10G Networking Driver(BNA).
> 
> The fix is to make BNA a module only driver.
> 
> Signed-off-by: Debashis Dutt <ddutt@brocade.com>
> Signed-off-by: Rasesh Mody <rmody@brocade.com>

You have to be kidding me.  This fix is totally unacceptable.

You have to go through your two drivers and:

1) Mark as 'static' symbols that don't actually need global
   visibility.

2) Make the two drivers use unique namespaces for the function
   names that must be globally visible for whatever reason.

You are really trying my patience, fix this properly and promptly
or I'm removing your driver from the tree.

RE: [net-next-2.6 1/1]: bna: Fix build break for allyesconfig

[Rasesh Mody]

>From: David Miller <mailto:davem@davemloft.net>
>Sent: Wednesday, August 25, 2010 3:23 PM
>
>From: Rasesh Mody <rmody@brocade.com>
>Date: Wed, 25 Aug 2010 14:32:10 -0700
>
>> From: Rasesh Mody <rmody@brocade.com>
>> 
>> This patch contains a fix for the build break caused by multiple
>> definitions of symbols between Brocade's FC/FCOE driver(BFA) 
>> and 10G Networking Driver(BNA).
>> 
>> The fix is to make BNA a module only driver.
>> 
>> Signed-off-by: Debashis Dutt <ddutt@brocade.com>
>> Signed-off-by: Rasesh Mody <rmody@brocade.com>
>
>You have to be kidding me.  This fix is totally unacceptable.
>
>You have to go through your two drivers and:
>
>1) Mark as 'static' symbols that don't actually need global
>   visibility.
>
>2) Make the two drivers use unique namespaces for the function
>   names that must be globally visible for whatever reason.
>
>You are really trying my patience, fix this properly and promptly
>or I'm removing your driver from the tree.

David,

We are working on fixing it properly. We will submit the patches as soon as possible.

Thanks,
Rasesh

Re: [net-next-2.6 1/1]: bna: Fix build break for allyesconfig

[David Miller]

From: Rasesh Mody <rmody@brocade.com>
Date: Wed, 25 Aug 2010 16:05:43 -0700

> We are working on fixing it properly. We will submit the patches as
> soon as possible.

Thank you.

Also, if this is essentially two copies of the same piece of code,
consider splitting it out into a seperate module in the future.  There
are a few drivers which do this, f.e. see the MLX4 driver, which
supports both a network device and an infiniband device out of the
same hardware, using a core of shared code in a seperate module called
mlx4_core which exports symbols to the network and infiniband drivers.