* [PATCH 1/2] bridge: fix locking comment
@ 2010-08-24 23:08 Stephen Hemminger
2010-08-25 23:39 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2010-08-24 23:08 UTC (permalink / raw)
To: David Miller; +Cc: netdev
The carrier check is not called from work queue in current code.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/net/bridge/br_if.c 2010-08-20 15:17:26.306400002 -0700
+++ b/net/bridge/br_if.c 2010-08-20 15:18:20.826400002 -0700
@@ -61,11 +61,7 @@ static int port_cost(struct net_device *
}
-/*
- * Check for port carrier transistions.
- * Called from work queue to allow for calling functions that
- * might sleep (such as speed check), and to debounce.
- */
+/* Check for port carrier transistions. */
void br_port_carrier_check(struct net_bridge_port *p)
{
struct net_device *dev = p->dev;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] bridge: fix locking comment
2010-08-24 23:08 [PATCH 1/2] bridge: fix locking comment Stephen Hemminger
@ 2010-08-25 23:39 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-08-25 23:39 UTC (permalink / raw)
To: shemminger; +Cc: netdev
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Tue, 24 Aug 2010 16:08:10 -0700
> The carrier check is not called from work queue in current code.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-25 23:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-24 23:08 [PATCH 1/2] bridge: fix locking comment Stephen Hemminger
2010-08-25 23:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).