From: David Miller <davem@davemloft.net>
To: ajitk@serverengines.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6 2/3] be2net: fix a bug in UE detection logic
Date: Wed, 25 Aug 2010 21:15:00 -0700 (PDT) [thread overview]
Message-ID: <20100825.211500.193701446.davem@davemloft.net> (raw)
In-Reply-To: <20100825.142311.115915728.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 25 Aug 2010 14:23:11 -0700 (PDT)
> From: Ajit Khaparde <ajitk@serverengines.com>
> Date: Wed, 25 Aug 2010 15:57:31 +0530
>
>> The ONLINE registers can return 0xFFFFFFFF on more than one
>> occassion. On systems that care, reading these registers could
>> lead to problems.
>>
>> So the new code decides that the ASIC has encountered and error
>> by reading the UE_STATUS_LOW/HIGH registers. AND them with
>> the mask values and a non-zero result indicates an error.
>>
>> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
>
> Applied.
You didn't even build test what you submitted to me:
ERROR: "be_dump_ue" [drivers/net/benet/be2net.ko] undefined!
I'm reverting both patches.
next prev parent reply other threads:[~2010-08-26 4:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 10:27 [PATCH net-2.6 2/3] be2net: fix a bug in UE detection logic Ajit Khaparde
2010-08-25 21:23 ` David Miller
2010-08-26 4:15 ` David Miller [this message]
2010-08-26 4:15 ` David Miller
2010-09-03 4:55 ` Ajit Khaparde
-- strict thread matches above, loose matches on Subject: below --
2010-09-03 16:23 Ajit Khaparde
2010-09-03 16:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100825.211500.193701446.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajitk@serverengines.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).