netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: greearb@candelatech.com
Cc: netdev@vger.kernel.org
Subject: Re: [net-next] ipv6: Enable netlink notification for tentative addresses.
Date: Wed, 25 Aug 2010 21:24:56 -0700 (PDT)	[thread overview]
Message-ID: <20100825.212456.71107442.davem@davemloft.net> (raw)
In-Reply-To: <1282760777-15381-1-git-send-email-greearb@candelatech.com>

From: Ben Greear <greearb@candelatech.com>
Date: Wed, 25 Aug 2010 11:26:17 -0700

> By default, netlink messages are not sent when an IPv6 address
> is added if it is in tentative state.  This makes it harder
> for user-space applications to know the current state of the
> IPv6 addresses.  This patch adds an ipv6 sysctl that will
> allow tentative address notifications to be sent.  The sysctl
> is off by default.
> 
> Signed-off-by: Ben Greear <greearb@candelatech.com>

It's inconsistent to send two NEWADDR events for the same add.

I would advise that we unconditionally do the NEWADDR once,
when the tentative state address is added, and completely
elide the one we current send when it leaves tentative state.

Having a sysctl, and having it off by default, just means you haven't
actually fixes the problem.  Since it's only fixed if someone makes a
non-standard configuration change.

Otherwise what you're saying is that this is a very obscure thing for
very obscure applications, and it very nearly doesn't even matter
as a result.


  reply	other threads:[~2010-08-26  4:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-25 18:26 [net-next] ipv6: Enable netlink notification for tentative addresses Ben Greear
2010-08-26  4:24 ` David Miller [this message]
2010-08-26 18:50   ` Ben Greear
2010-08-26 19:57     ` Brian Haley
2010-08-26 20:18       ` David Miller
2010-08-26 21:19         ` Ben Greear
2010-08-26 21:27           ` David Miller
2010-08-27  4:24             ` Ben Greear
2010-08-26 21:22       ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100825.212456.71107442.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=greearb@candelatech.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).