From: Arnd Bergmann <arnd@arndb.de>
To: Ben Greear <greearb@candelatech.com>
Cc: netdev@vger.kernel.org
Subject: Re: [net-next 2/2] macvlan: Enable qdisc backoff logic.
Date: Wed, 25 Aug 2010 21:59:11 +0200 [thread overview]
Message-ID: <201008252159.11227.arnd@arndb.de> (raw)
In-Reply-To: <4C756EAF.9090704@candelatech.com>
On Wednesday 25 August 2010 21:27:43 Ben Greear wrote:
> > I suppose we need to do something in macvtap to handle this as
> > well, right? A guest trying to send a frame through qemu
> > or vhost net into macvtap needs to be prevented from sending
> > more when we get into this path. Right now, we just ignore
> > the return value of macvlan_start_xmit.
>
> I have a similar, though slightly more complex, patch for 802.1q
> vlans, but I haven't looked at macvtap at all.
>
> If these two patches are accepted, I'll post the .1q patch as well.
I think one of us needs to fix macvtap in order for your patch to
go in, because otherwise there is a memory leak or worse when
macvtap fails to retransmit the frame.
Arnd
next prev parent reply other threads:[~2010-08-25 19:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 19:00 [net-next 1/2] qdisc: Allow qdiscs to provide backpressure up the stack Ben Greear
2010-08-25 19:00 ` [net-next 2/2] macvlan: Enable qdisc backoff logic Ben Greear
2010-08-25 19:24 ` Arnd Bergmann
2010-08-25 19:27 ` Ben Greear
2010-08-25 19:38 ` Hagen Paul Pfeifer
2010-08-25 19:49 ` Ben Greear
2010-08-25 19:59 ` Arnd Bergmann [this message]
2010-08-25 20:49 ` Ben Greear
2010-08-26 13:55 ` Arnd Bergmann
2010-08-26 15:33 ` Ben Greear
2010-08-26 17:45 ` Ben Greear
2010-08-27 13:16 ` Arnd Bergmann
2010-08-25 20:44 ` [net-next 1/2] qdisc: Allow qdiscs to provide backpressure up the stack Stephen Hemminger
2010-08-25 20:56 ` Ben Greear
2010-08-26 22:59 ` David Miller
2010-08-27 4:14 ` Ben Greear
2010-08-27 4:34 ` David Miller
2010-08-27 5:22 ` Ben Greear
2010-08-27 5:36 ` David Miller
2010-08-27 5:58 ` Ben Greear
2010-08-27 6:11 ` David Miller
2010-08-27 15:26 ` Ben Greear
2010-08-27 15:59 ` Eric Dumazet
2010-08-27 17:00 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008252159.11227.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).