From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6 v3] gro: __napi_gro_receive() optimizations
Date: Thu, 26 Aug 2010 22:02:15 -0700 (PDT) [thread overview]
Message-ID: <20100826.220215.39172437.davem@davemloft.net> (raw)
In-Reply-To: <20100827044201.GA24224@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 26 Aug 2010 21:42:01 -0700
> On Thu, Aug 26, 2010 at 09:38:16PM -0700, David Miller wrote:
>> From: Eric Dumazet <eric.dumazet@gmail.com>
>> Date: Fri, 27 Aug 2010 06:35:13 +0200
>>
>> > + fold |= *(unsigned long *)(a + 6) ^ *(unsigned long *)(b + 6);
>>
>> Shouldn't these be "+ 8" instead of "+ 6"?
>
> I think +6 is right since we're trying to compare 14 bytes worth
> of data.
Indeed, thanks. I need to borrow some brain cells :)
next prev parent reply other threads:[~2010-08-27 5:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 20:33 [PATCH net-next-2.6] gro: __napi_gro_receive() optimizations Eric Dumazet
2010-08-25 20:45 ` Stephen Hemminger
2010-08-25 20:54 ` Eric Dumazet
2010-08-25 20:57 ` David Miller
2010-08-25 21:15 ` Eric Dumazet
2010-08-26 7:51 ` David Miller
2010-08-26 9:03 ` Eric Dumazet
2010-08-27 4:35 ` [PATCH net-next-2.6 v3] " Eric Dumazet
2010-08-27 4:38 ` David Miller
2010-08-27 4:42 ` Herbert Xu
2010-08-27 5:02 ` David Miller [this message]
2010-08-27 4:43 ` Eric Dumazet
2010-08-27 5:01 ` David Miller
2010-08-27 5:01 ` [PATCH net-next-2.6 v4] " Eric Dumazet
2010-08-27 5:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100826.220215.39172437.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).