From: David Miller <davem@davemloft.net>
To: eilong@broadcom.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, vladz@broadcom.com
Subject: Re: [PATCH] bnx2x: fix wrong return from bnx2x_trylock_hw_lock
Date: Thu, 26 Aug 2010 22:04:00 -0700 (PDT) [thread overview]
Message-ID: <20100826.220400.115912823.davem@davemloft.net> (raw)
In-Reply-To: <1282884884.14181.1.camel@lb-tlvb-eilong.il.broadcom.com>
From: "Eilon Greenstein" <eilong@broadcom.com>
Date: Fri, 27 Aug 2010 07:54:44 +0300
> On Thu, 2010-08-26 at 20:49 -0700, Eric Dumazet wrote:
>> bnx2x_trylock_hw_lock() returns a bool :
>>
>> true if succeeded to acquire the lock.
>> false in case of error.
>>
>> -EINVAL is not an acceptable value, since its promoted to true.
>
> Indeed - thanks Eric!
>
>> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Acked-by: Eilon Greenstein <eilong@broadcom.com>
Applied.
next prev parent reply other threads:[~2010-08-27 5:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 3:49 [PATCH] bnx2x: fix wrong return from bnx2x_trylock_hw_lock Eric Dumazet
2010-08-27 4:54 ` Eilon Greenstein
2010-08-27 5:04 ` David Miller [this message]
2010-08-27 5:07 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100826.220400.115912823.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vladz@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox