netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: greearb@candelatech.com
Cc: netdev@vger.kernel.org
Subject: Re: [net-next 1/2] qdisc: Allow qdiscs to provide backpressure up the stack.
Date: Thu, 26 Aug 2010 22:36:04 -0700 (PDT)	[thread overview]
Message-ID: <20100826.223604.48516081.davem@davemloft.net> (raw)
In-Reply-To: <4C774B8F.2030805@candelatech.com>

From: Ben Greear <greearb@candelatech.com>
Date: Thu, 26 Aug 2010 22:22:23 -0700

> On 08/26/2010 09:34 PM, David Miller wrote:
>> From: Ben Greear<greearb@candelatech.com>
>> Date: Thu, 26 Aug 2010 21:14:39 -0700
>>
>>> I'll look into the NET_XMIT_CN, but if that propagates backpressure up
>>> through mac-vlan, then something must know how to re-start the tx
>>> logic.
>>
>> It doesn't need to, as it drops and frees up the packet.
> 
> If there were 5 pkts in the socket buffer, and the attempt to
> send the first one caused NET_XMIT_CN, then
> based on your comment below about UDP being throttled, I assume
> the other 4 are kept until later?

It only has an effect on TCP, it causes it to decrease the
congestion window limits.

I did not state that it had any effect on UDP.  Just because I
talk about UDP later in my email doesn't mean the two things
are related.

  reply	other threads:[~2010-08-27  5:35 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-25 19:00 [net-next 1/2] qdisc: Allow qdiscs to provide backpressure up the stack Ben Greear
2010-08-25 19:00 ` [net-next 2/2] macvlan: Enable qdisc backoff logic Ben Greear
2010-08-25 19:24   ` Arnd Bergmann
2010-08-25 19:27     ` Ben Greear
2010-08-25 19:38       ` Hagen Paul Pfeifer
2010-08-25 19:49         ` Ben Greear
2010-08-25 19:59       ` Arnd Bergmann
2010-08-25 20:49         ` Ben Greear
2010-08-26 13:55           ` Arnd Bergmann
2010-08-26 15:33             ` Ben Greear
2010-08-26 17:45             ` Ben Greear
2010-08-27 13:16               ` Arnd Bergmann
2010-08-25 20:44 ` [net-next 1/2] qdisc: Allow qdiscs to provide backpressure up the stack Stephen Hemminger
2010-08-25 20:56   ` Ben Greear
2010-08-26 22:59 ` David Miller
2010-08-27  4:14   ` Ben Greear
2010-08-27  4:34     ` David Miller
2010-08-27  5:22       ` Ben Greear
2010-08-27  5:36         ` David Miller [this message]
2010-08-27  5:58           ` Ben Greear
2010-08-27  6:11             ` David Miller
2010-08-27 15:26               ` Ben Greear
2010-08-27 15:59                 ` Eric Dumazet
2010-08-27 17:00                   ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100826.223604.48516081.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=greearb@candelatech.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).