From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: tklauser@distanz.ch, netdev@vger.kernel.org
Subject: Re: [PATCH v3] slip: Use net_device_stats from struct net_device
Date: Fri, 27 Aug 2010 19:26:18 -0700 (PDT) [thread overview]
Message-ID: <20100827.192618.193702625.davem@davemloft.net> (raw)
In-Reply-To: <1282897693.2487.2.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 27 Aug 2010 10:28:13 +0200
> Le vendredi 27 août 2010 à 10:12 +0200, Tobias Klauser a écrit :
>> Use net_device->stats for stats instead of private variable copies in
>> struct slip. Use ndo_get_stat64 so the additions can be performed on a private
>> destination buffer.
>>
>> Cc: Eric Dumazet <eric.dumazet@gmail.com>
>> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
>> ---
>> drivers/net/slip.c | 61 ++++++++++++++++++++++++++-------------------------
>> drivers/net/slip.h | 9 -------
>> 2 files changed, 31 insertions(+), 39 deletions(-)
>>
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks everyone.
prev parent reply other threads:[~2010-08-28 2:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 8:25 [PATCH] slip: Use net_device_stats from struct net_device Tobias Klauser
2010-08-19 8:49 ` Eric Dumazet
2010-08-19 9:12 ` Tobias Klauser
2010-08-26 8:28 ` [PATCH v2] " Tobias Klauser
2010-08-26 8:39 ` Eric Dumazet
2010-08-26 9:18 ` Tobias Klauser
2010-08-27 8:12 ` [PATCH v3] " Tobias Klauser
2010-08-27 8:28 ` Eric Dumazet
2010-08-28 2:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100827.192618.193702625.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).