Re: [PATCH] sky2: don't do GRO on second port

Eric Dumazet
2010-09-03T05:30:27Z

Le vendredi 03 septembre 2010 à 05:26 +0800, Herbert Xu a écrit :
> On Thu, Sep 02, 2010 at 12:41:45PM +0200, Eric Dumazet wrote:
> >
> > [PATCH net-next-2.6] gro: remove use of napi->dev
> >
> > Only use of napi->dev in GRO stack is the one found in napi_get_frags()
> >
> > We can remove it and use a plain dev_alloc_skb() call.
> >
> > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> Why do you think napi->dev is not needed?

Origin was that sky2 could use one napi and two devices on it.
No bug, only a conceptual problem using a napi->dev.

Then, there is a small second point :

netdev_alloc_skb_ip_align() is using 'device' NUMA node to allocate
memory.

In this context, this makes litle sense because this skb is not going to
be used by the device. Its a pure software one, for the sake of GRO
handling.

It would be more efficient to allocate an skb on NUMA node of the CPU
handling the softirq.

Thanks