Re: [RFC] gro: Is it ok to share a single napi from several devs ?

Eric Dumazet
2010-08-29T18:39:27Z

Le dimanche 29 août 2010 à 10:06 -0700, David Miller a écrit :
> From: Jarek Poplawski <jarkao2@gmail.com>
> Date: Sun, 29 Aug 2010 11:59:51 +0200
>
> > Actually, when GRO compares napi->dev to skb->dev?
>
> Hmmm, I thought the code made a skb->dev comparison with the
> existing SKBs in the list when checking for same-flow matches.
>
> It doesn't, probably based upon the assumption that a NAPI
> instance maps to a unique device, the very topic we're
> discussing right now :-/
>
>

It does the check, Stephen added it in the commit I mentioned to start
this thread.

With net-next-2.6 this now reads :