From: Jarek Poplawski <jarkao2@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
shemminger@vyatta.com, herbert@gondor.apana.org.au,
netdev@vger.kernel.org
Subject: Re: [RFC] gro: Is it ok to share a single napi from several devs ?
Date: Mon, 30 Aug 2010 06:42:31 +0000 [thread overview]
Message-ID: <20100830064231.GA7060@ff.dom.local> (raw)
In-Reply-To: <1283107162.2297.32.camel@edumazet-laptop>
On 2010-08-29 20:39, Eric Dumazet wrote:
> Le dimanche 29 aoĂťt 2010 Ă 10:06 -0700, David Miller a ĂŠcrit :
>> From: Jarek Poplawski <jarkao2@gmail.com>
>> Date: Sun, 29 Aug 2010 11:59:51 +0200
>>
>>> Actually, when GRO compares napi->dev to skb->dev?
>>
>> Hmmm, I thought the code made a skb->dev comparison with the
>> existing SKBs in the list when checking for same-flow matches.
>>
>> It doesn't, probably based upon the assumption that a NAPI
>> instance maps to a unique device, the very topic we're
>> discussing right now :-/
>>
>>
>
> It does the check, Stephen added it in the commit I mentioned to start
> this thread.
>
> With net-next-2.6 this now reads :
>
Since Stephen didn't seem to miss this too much it seems quite obvious
to me this check should be removed.
Jarek P.
next prev parent reply other threads:[~2010-08-30 6:42 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 20:50 [PATCH] net: Fix vlan_gro_frags vs netpoll and bonding paths Jarek Poplawski
2010-08-28 0:13 ` Herbert Xu
2010-08-28 9:44 ` Jarek Poplawski
2010-08-28 10:54 ` [RFC] gro: Is it ok to share a single napi from several devs ? Eric Dumazet
2010-08-28 14:31 ` Jarek Poplawski
2010-08-28 14:48 ` Eric Dumazet
2010-08-28 15:16 ` Jarek Poplawski
2010-08-28 17:14 ` Stephen Hemminger
2010-08-28 21:41 ` David Miller
2010-08-28 22:31 ` Stephen Hemminger
2010-08-28 22:33 ` David Miller
2010-08-29 9:59 ` Jarek Poplawski
2010-08-29 17:06 ` David Miller
2010-08-29 18:39 ` Eric Dumazet
2010-08-30 6:42 ` Jarek Poplawski [this message]
2010-08-30 15:57 ` Stephen Hemminger
2010-08-30 16:50 ` David Miller
2010-08-30 17:51 ` [PATCH] sky2: don't do GRO on second port Stephen Hemminger
2010-08-30 19:09 ` Jarek Poplawski
2010-09-01 21:51 ` David Miller
2010-09-01 21:55 ` Stephen Hemminger
2010-09-02 9:18 ` Jarek Poplawski
2010-09-02 12:53 ` Jarek Poplawski
2010-09-02 16:30 ` David Miller
2010-09-02 16:48 ` Jarek Poplawski
2010-09-02 8:33 ` Jarek Poplawski
2010-09-02 9:31 ` Eric Dumazet
2010-09-02 9:55 ` Jarek Poplawski
2010-09-02 10:41 ` Eric Dumazet
2010-09-02 11:02 ` Jarek Poplawski
2010-09-02 12:09 ` Eric Dumazet
2010-09-02 12:28 ` Jarek Poplawski
2010-09-02 17:08 ` David Miller
2010-09-02 21:26 ` Herbert Xu
2010-09-03 5:23 ` Eric Dumazet
2010-09-02 9:32 ` Jarek Poplawski
2010-08-30 18:36 ` [RFC] gro: Is it ok to share a single napi from several devs ? Jarek Poplawski
2010-08-30 19:59 ` [RFC] netpoll: " Eric Dumazet
2010-08-30 20:12 ` Stephen Hemminger
2010-08-30 20:19 ` Eric Dumazet
-- strict thread matches above, loose matches on Subject: below --
2010-08-29 4:07 [RFC] gro: " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100830064231.GA7060@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).