netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Helmut Schaa <helmut.schaa-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
To: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Krishna Kumar <krkumar2-xthvdsQ13ZrQT0dZR+AlfA@public.gmane.org>,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: mac80211 using different tx queue for frames with same TID and RA
Date: Mon, 30 Aug 2010 16:01:12 +0200	[thread overview]
Message-ID: <201008301601.12971.helmut.schaa@googlemail.com> (raw)

Hi,

while debugging an issue in rt2x00 I've discovered that in some cases frames
with the same TID and RA end up in different tx queues (which causes problems
in rt2x00 when using aggregation).

Is this behavior expected and we need to handle that case in rt2x00 or is it
more likely a bug? At least I thought the select_queue implementation in
mac80211 was meant to always pick the same tx queue for skbs with the same
priority and hence it shouldn't happen that frames with the same TID are
queued into different tx queues.

This behavior seems to have changed already a while ago with the patch
"net: Use sk_tx_queue_mapping for connected sockets" (CC'ing Krishna & netdev).

Thanks,
Helmut
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2010-08-30 14:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-30 14:01 Helmut Schaa [this message]
     [not found] ` <201008301601.12971.helmut.schaa-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2010-08-30 14:11   ` mac80211 using different tx queue for frames with same TID and RA Johannes Berg
     [not found]     ` <1283177480.3691.66.camel-8upI4CBIZJIJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2010-08-30 14:34       ` Helmut Schaa
     [not found]         ` <201008301634.10122.helmut.schaa-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2010-08-30 14:41           ` Johannes Berg
     [not found]             ` <1283179307.3691.73.camel-8upI4CBIZJIJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2010-08-30 14:50               ` Helmut Schaa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201008301601.12971.helmut.schaa@googlemail.com \
    --to=helmut.schaa-gm/ye1e23mwn+bqq9rbeug@public.gmane.org \
    --cc=krkumar2-xthvdsQ13ZrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).