From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, joe@perches.com
Subject: Re: [PATCH net-next-2.6] net: add a comment on netdev->last_rx
Date: Tue, 31 Aug 2010 13:37:27 -0700 (PDT) [thread overview]
Message-ID: <20100831.133727.235702469.davem@davemloft.net> (raw)
In-Reply-To: <1283276416.2550.140.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 31 Aug 2010 19:40:16 +0200
> As some driver authors seem to reintroduce dev->last_rx use,
> add a comment to strongly discourage this.
>
> Since commit 6cf3f41e6c0 (bonding, net: Move last_rx update into bonding
> recv logic), network drivers dont need to update last_rx themselves,
> unless they use this field to implement a timeout.
>
> Not updating last_rx helps not dirtying a cache line, improving
> performance in SMP.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
prev parent reply other threads:[~2010-08-31 20:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 17:40 [PATCH net-next-2.6] net: add a comment on netdev->last_rx Eric Dumazet
2010-08-31 20:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100831.133727.235702469.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).