From: Stephen Hemminger <shemminger@vyatta.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next-2.6] skge: add GRO support
Date: Tue, 31 Aug 2010 18:31:05 -0700 [thread overview]
Message-ID: <20100831183105.03b0f2bc@nehalam> (raw)
In-Reply-To: <1283293956.2198.46.camel@edumazet-laptop>
On Wed, 01 Sep 2010 00:32:36 +0200
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> @@ -3193,7 +3192,7 @@ static int skge_poll(struct napi_struct *napi, int to_do)
> unsigned long flags;
>
> spin_lock_irqsave(&hw->hw_lock, flags);
> - __napi_complete(napi);
> + napi_complete(napi);
This adds a redundant irq_save/irq_restore in the packet
receive path.
In the case of skge, since the both ports share a single
IRQ mask register, the lock is there to make sure that updates
to the mask register doesn't race between NAPI finishing
on one port and IRQ on other port changing same IRQ mask register.
next prev parent reply other threads:[~2010-09-01 1:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 22:32 [PATCH net-next-2.6] skge: add GRO support Eric Dumazet
2010-09-01 1:31 ` Stephen Hemminger [this message]
2010-09-01 4:25 ` Eric Dumazet
2010-09-01 17:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100831183105.03b0f2bc@nehalam \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).