From: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
To: Dan Kruchinin <dkruchinin@acm.org>
Cc: Jarek Poplawski <jarkao2@gmail.com>,
netdev@vger.kernel.org, Stephen Hemminger <shemminger@osdl.org>
Subject: Re: [RFC][PATCH] QoS TBF and latency configuration misbehavior
Date: Wed, 1 Sep 2010 02:34:02 +0400 [thread overview]
Message-ID: <20100831223402.GA7101@ms2.inr.ac.ru> (raw)
In-Reply-To: <20100831214808.GA32141@ms2.inr.ac.ru>
Hello!
Hmm. Seems, you are right and I was wrong all these years.
Somehow, I did wrong calculation once and this rustied to the brains.
After some thinking the calulation is obviously wrong: no matter what,
in steady state tbf queue is processed with rate R. What a stupid mistake... :-)
Please, also think how to fix the second part of calculation which deals
with peak rate. IMHO (for now :-)) it does not even contribute to latency
and should be deleted.
To Jarek: about the scripts. I do not think something will be broken
by fixing this error. Eventually, if someone used "latency", he meant
something about real latency. And even if the value was generated
using the same wrong logic as tc did, using correct formula would just
increase limit setting.
Alexey
next prev parent reply other threads:[~2010-08-31 22:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 13:56 [RFC][PATCH] QoS TBF and latency configuration misbehavior Dan Kruchinin
2010-08-31 17:01 ` Dan Kruchinin
2010-08-31 19:57 ` Jarek Poplawski
2010-08-31 21:00 ` Dan Kruchinin
2010-08-31 21:47 ` Jarek Poplawski
2010-08-31 21:48 ` Alexey Kuznetsov
2010-08-31 22:34 ` Alexey Kuznetsov [this message]
2010-09-01 6:36 ` Jarek Poplawski
2010-09-01 8:40 ` Alexey Kuznetsov
2010-09-01 11:29 ` Dan Kruchinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100831223402.GA7101@ms2.inr.ac.ru \
--to=kuznet@ms2.inr.ac.ru \
--cc=dkruchinin@acm.org \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).