From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: acme@ghostprotocols.net, andrew.hendry@gmail.com,
elendil@planet.nl, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] wan: make driver strings const
Date: Wed, 01 Sep 2010 19:19:21 -0700 (PDT) [thread overview]
Message-ID: <20100901.191921.66727586.davem@davemloft.net> (raw)
In-Reply-To: <20100901.182014.141246825.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 01 Sep 2010 18:20:14 -0700 (PDT)
> From: Stephen Hemminger <shemminger@vyatta.com>
> Date: Wed, 1 Sep 2010 18:15:15 -0700
>
>> Change several wan drivers to make strings and other initialize
>> only parameters const.
>>
>> Compile tested only.
>>
>> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> Applied, thanks.
You may have "compile tested", but you certainly didn't watch out
for new warnings:
drivers/net/wan/cycx_drv.c: In function 'cycx_setup':
drivers/net/wan/cycx_drv.c:141:2: warning: passing argument 1 of 'get_option_index' discards qualifiers from pointer target type
drivers/net/wan/cycx_drv.c:76:12: note: expected 'long int *' but argument is of type 'const long int *'
drivers/net/wan/cycx_drv.c:151:2: warning: passing argument 1 of 'get_option_index' discards qualifiers from pointer target type
drivers/net/wan/cycx_drv.c:76:12: note: expected 'long int *' but argument is of type 'const long int *'
I've reverted your patch.
next prev parent reply other threads:[~2010-09-02 2:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 1:15 [PATCH net-next] wan: make driver strings const Stephen Hemminger
2010-09-02 1:20 ` David Miller
2010-09-02 2:19 ` David Miller [this message]
2010-09-03 0:29 ` Stephen Hemminger
2010-09-06 20:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100901.191921.66727586.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@ghostprotocols.net \
--cc=andrew.hendry@gmail.com \
--cc=elendil@planet.nl \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).